Merge pull request #458 from AvdN/daemonize_deprecation-2

views: issue warning on use of .daemonize

doc/content/demos/daemonized-view/daemonized-view.py

@@ -46,7 +46,7 @@ def handle_request(self, request):
         )
 
         # tell Lona to not kill the view when the page gets refreshed
-        self.daemonize()
+        self.is_daemon = True
 
         while True:
             self.show(html)

lona/html/node.py

@@ -13,6 +13,7 @@
 from lona.protocol import NODE_TYPE
 from lona.html.widget import Widget
 from lona.state import State
+import lona.warnings
 
 
 def parse_style_string(style_string: str) -> dict[str, str]:
@@ -457,3 +458,10 @@ def show(self):
         with self.lock:
             if 'display' in self.style and self.style['display'] == 'none':
                 del self.style['display']
+
+
+class DeprecatedNode(Node):
+
+    def __init__(self, *args, **kwargs):
+        lona.warnings.remove_2_0(_class=True)
+        super().__init__(*args, **kwargs)

lona/html/nodes/forms/__init__.py

@@ -1,5 +1,5 @@
+from lona.html.node import DeprecatedNode, Node
 from lona.events.event_types import CLICK
-from lona.html.node import Node
 
 
 class Button(Node):
@@ -25,7 +25,7 @@ def disabled(self, new_value):
             del self.attributes['disabled']
 
 
-class Datalist(Node):
+class Datalist(DeprecatedNode):
     # TODO: remove in 2.0
 
     TAG_NAME = 'datalist'
@@ -35,7 +35,7 @@ class DataList(Node):
     TAG_NAME = 'datalist'
 
 
-class Fieldset(Node):
+class Fieldset(DeprecatedNode):
     # TODO: remove in 2.0
 
     TAG_NAME = 'fieldset'

lona/html/nodes/forms/select.py

@@ -1,14 +1,14 @@
 from lona.events.event_types import CHANGE
-from lona.html.node import Node
+from lona.html.node import DeprecatedNode
 
 
-class Option(Node):
+class Option(DeprecatedNode):
     # TODO: remove in 2.0
 
     TAG_NAME = 'option'
 
 
-class Select(Node):
+class Select(DeprecatedNode):
     # TODO: remove in 2.0
 
     TAG_NAME = 'select'

lona/html/parsing.py

@@ -14,6 +14,7 @@
 from lona.html.nodes.text_content import Div
 from lona.html.text_node import TextNode
 from lona.html.node import Node
+import lona.warnings
 
 logger = logging.getLogger('lona')
 
@@ -270,6 +271,7 @@ def HTML(
 
             # html string
             elif '<' in node or '>' in node:
+                lona.warnings.remove_2_0('HTML parsing')
                 parsed_nodes = cast(
                     list,
                     parse_html(

lona/templating.py

@@ -7,6 +7,7 @@
 
 from lona.compat import get_client_version
 from lona.protocol import get_enum_values
+import lona.warnings
 
 logger = logging.getLogger('lona.templating')
 
@@ -40,6 +41,7 @@ def state(self):
     def client_version(self):
         # TODO: remove in Lona 2.0
 
+        lona.warning.remove_2_0()
         return get_client_version()
 
     def load_stylesheets(self):

lona/view.py

@@ -15,6 +15,7 @@
 from lona.connection import Connection
 from lona.channels import Channel
 from lona.request import Request
+import lona.warnings
 
 # avoid import cycles
 if TYPE_CHECKING:  # pragma: no cover
@@ -349,6 +350,11 @@ def sleep(self, delay: float, result: T | None = None) -> T | None:
     def daemonize(self) -> None:
         # TODO: remove in 2.0
 
+        lona.warnings.warn(  # NOQA: G010
+            '.daemonize() is deprecated, use .is_daemon = True\n  (see: https://lona-web.org/1.x/api-reference/views.html#lonaview-daemonize)',
+            lona.warnings.DaemonizeDeprecationWarning,
+            stacklevel=2,
+        )
         self.is_daemon = True
 
     def ping(self) -> Literal['pong']:

lona/warnings.py

@@ -1,8 +1,9 @@
-import warnings as orginal_warnings
+import warnings as original_warnings
+import inspect
 
 
 class ExtendedWarn:
-    warn = orginal_warnings.warn
+    warn = original_warnings.warn
 
     def __call__(
         self, message, category=None, stacklevel=1, source=None, callee=None,
@@ -22,9 +23,9 @@ def __call__(
 
 
 warn = ExtendedWarn()
-orginal_warnings.warn = warn  # type: ignore
+original_warnings.warn = warn  # type: ignore
 
-_original_formatwarning = orginal_warnings.formatwarning
+_original_formatwarning = original_warnings.formatwarning
 
 
 def _formatwarning_with_callee(message, category, filename, lineno, line):
@@ -43,13 +44,35 @@ def _formatwarning_with_callee(message, category, filename, lineno, line):
     return _original_formatwarning(message, category, filename, lineno, line)
 
 
-orginal_warnings.formatwarning = _formatwarning_with_callee  # type: ignore
+original_warnings.formatwarning = _formatwarning_with_callee  # type: ignore
 
 
-class DictResponseDeprecationWarning(PendingDeprecationWarning):
+class Lona_2_0_DeprecationWarning(PendingDeprecationWarning):
     pass
 
 
-orginal_warnings.simplefilter(
-    'once', category=DictResponseDeprecationWarning,
+original_warnings.simplefilter(
+    'once', category=Lona_2_0_DeprecationWarning,
 )
+
+
+class DictResponseDeprecationWarning(Lona_2_0_DeprecationWarning):
+    pass
+
+
+class DaemonizeDeprecationWarning(Lona_2_0_DeprecationWarning):
+    pass
+
+
+def remove_2_0(msg=None, _class=False):
+    if msg is None:
+        if _class:
+            msg = 'class '
+            msg += inspect.stack()[1].frame.f_locals['self'].__class__.__name__
+        else:
+            msg = inspect.stack()[1].function + '()'
+    original_warnings.warn(  # NOQA: G010
+        msg + ' will be removed in 2.0',  # NOQA: G003
+        Lona_2_0_DeprecationWarning,
+        stacklevel=2,
+    )