feat(status): Added status on translation values

lokappio · Dec 22, 2023 · 83becbd · 83becbd
1 parent a4beaac
commit 83becbd
Show file tree

Hide file tree

Showing 4 changed files with 30 additions and 4 deletions.
diff --git a/postman-collection/Lokapp API.postman_collection.json b/postman-collection/Lokapp API.postman_collection.json
@@ -811,7 +811,7 @@
 								"header": [],
 								"body": {
 									"mode": "raw",
-									"raw": "{\n    \"name\": \"first_translation_key\",\n    \"group_id\": 1,\n    \"is_plural\": false\n}",
+									"raw": "{\n    \"name\": \"first_translation_key\",\n    \"groupId\": 1,\n    \"isPlural\": false\n}",
 									"options": {
 										"raw": {
 											"language": "json"
@@ -944,7 +944,7 @@
 								"header": [],
 								"body": {
 									"mode": "raw",
-									"raw": "{\n    \"name\": \"edited_translation_key\",\n    \"group_id\": 1,\n    \"is_plural\": false\n}",
+									"raw": "{\n    \"name\": \"edited_translation_key\",\n    \"groupId\": 1,\n    \"isPlural\": false\n}",
 									"options": {
 										"raw": {
 											"language": "json"
@@ -992,7 +992,7 @@
 								"header": [],
 								"body": {
 									"mode": "raw",
-									"raw": "{\n    \"name\": \"Content of the translation value\",\n    \"language_id\": 1,\n    \"quantity_string\": null\n}",
+									"raw": "{\n    \"name\": \"Content of the translation value\",\n    \"languageId\": 1,\n    \"quantityString\": null\n}",
 									"options": {
 										"raw": {
 											"language": "json"

diff --git a/src/translation/translation_status.enum.ts b/src/translation/translation_status.enum.ts
@@ -0,0 +1,7 @@
+enum TranslationStatus {
+  MODIFIED = "modified",
+  VALIDATED = "validated",
+  INVALIDATED = "invalidated"
+}
+
+export default TranslationStatus;
diff --git a/src/translation/translation_value.entity.ts b/src/translation/translation_value.entity.ts
@@ -3,6 +3,7 @@ import Language from "../languages/language.entity";
 import {Column, CreateDateColumn, Entity, JoinColumn, ManyToOne, PrimaryGeneratedColumn, Unique, UpdateDateColumn} from "typeorm";
 import TranslationKey from "./translation_key.entity";
 import {PostgresUniqueKeys} from "../data/database/postgres-unique-keys.enum";
+import TranslationStatus from "./translation_status.enum";
 
 export const TranslationValuesTableName: string = "translation_values";
 
@@ -46,4 +47,8 @@ export default class TranslationValue {
   @JoinColumn({name: "languageId"})
   @ApiHideProperty()
   public language: Language;
-}
+
+  @Column({default: TranslationStatus.MODIFIED, nullable: false})
+  @ApiProperty()
+  public status: TranslationStatus;
+}
diff --git a/tests/translation-values/translation-values.e2e-spec.ts b/tests/translation-values/translation-values.e2e-spec.ts
@@ -17,6 +17,7 @@ import TestsHelpers from "../helpers/tests.helpers";
 import * as request from "supertest";
 import CreateValueDto from "../../src/translation/dto/create-value.dto";
 import Role from "../../src/roles/role.enum";
+import TranslationStatus from "../../src/translation/translation_status.enum";
 
 describe("Translations values E2E", () => {
   let app: INestApplication;
@@ -230,13 +231,21 @@ describe("Translations values E2E", () => {
         .set("mocked_user_id", TestsHelpers.MOCKED_USER_ID_1)
         .send({name: "Content of the translation value", languageId: populatedLanguages[0].id, quantityString: null});
       expect(createResp.status).toEqual(201);
+      expect(createResp.body.name).toEqual("Content of the translation value");
+      expect(createResp.body.keyId).toEqual(populatedTranslationKeys[0].id);
+      expect(createResp.body.languageId).toEqual(populatedLanguages[0].id);
+      expect(createResp.body.status).toEqual(TranslationStatus.MODIFIED);
 
       const createWithoutQuantityResp = await request(app.getHttpServer())
         .post(`/projects/${populatedProjects[0].id}/translations/${populatedTranslationKeys[0].id}/values`)
         .auth("mocked.jwt", {type: "bearer"})
         .set("mocked_user_id", TestsHelpers.MOCKED_USER_ID_1)
         .send({name: "Content of the translation value", languageId: populatedLanguages[1].id});
       expect(createWithoutQuantityResp.status).toEqual(201);
+      expect(createResp.body.name).toEqual("Content of the translation value");
+      expect(createResp.body.keyId).toEqual(populatedTranslationKeys[0].id);
+      expect(createResp.body.languageId).toEqual(populatedLanguages[1].id);
+      expect(createResp.body.status).toEqual(TranslationStatus.MODIFIED);
 
       const values = await findTranslationValues(populatedTranslationKeys[0].id);
       expect(values.length).toEqual(2);
@@ -269,6 +278,11 @@ describe("Translations values E2E", () => {
         .set("mocked_user_id", TestsHelpers.MOCKED_USER_ID_1)
         .send({name: "Content of the translation value", languageId: populatedLanguages[0].id, quantityString: QuantityString.OTHER});
       expect(createResp.status).toEqual(201);
+      expect(createResp.body.name).toEqual("Content of the translation value");
+      expect(createResp.body.keyId).toEqual(populatedTranslationKeys[0].id);
+      expect(createResp.body.languageId).toEqual(populatedLanguages[0].id);
+      expect(createResp.body.quantityString).toEqual(QuantityString.OTHER);
+      expect(createResp.body.status).toEqual(TranslationStatus.MODIFIED);
 
       const values = await findTranslationValues(createdKey.id);
       expect(values.length).toEqual(1);