add 'unauthenticated' event, fix 'unsubscribed' event capabilities, update missing typedefs #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… allow advanced logging catch ServerClient (unavailable via reporter interface)
…rverNodeId (server-initiated -ch) or clientNodeId (client-initiated -ch)
…erverClient by evicting nodeIds / clientIds later, after unsubscribe
|
Can you add a description for PR? |
|
Added some motivation |
|
I needed a reason of changes. Now it is great. It is minor change ( |
|
Not at all — already applied a patch |
ai
reviewed
Aug 13, 2023
server-client/index.test.ts
Outdated
| @@ -257,9 +257,15 @@ it('removes itself on destroy', async () => { | |||
| '10:client2': { filters: { '{}': true } } | |||
| } | |||
| } | |||
| let unsubscribedClientNodeIds: string[] = [] | |||
| test.app.on('unsubscribed', (action, meta, clientNodeId) => { | |||
| unsubscribedClientNodeIds.push(clientNodeId) | |||
ai
reviewed
Aug 13, 2023
| @@ -657,7 +657,7 @@ export class BaseServer { | |||
| } | |||
| } | |||
| } | |||
| this.emitter.emit('unsubscribed', action, meta) | |||
| this.emitter.emit('unsubscribed', action, meta, clientNodeId) | |||
There was a problem hiding this comment.
Why do we need extra parameter? We can use parseId(meta.id).clientId
There was a problem hiding this comment.
Because in case of server-side channels cleanup (e.g. client is disconnected because of timeout), nodeId is server.nodeId
Line 172 in ebc9815
ai
pushed a commit
that referenced
this pull request
Oct 8, 2023
…pdate missing typedefs (#147) * add missing 'addClean' reporter type definition * add BaseServer 'unauthenticated' event on par with 'authenticated' to allow advanced logging catch ServerClient (unavailable via reporter interface) * add 'unsubscribed' event clientNodeId last arg (that can be either serverNodeId (server-initiated -ch) or clientNodeId (client-initiated -ch) * ClientServerdestroy: allow 'unsubscribed' event handler to retrieve ServerClient by evicting nodeIds / clientIds later, after unsubscribe * fix indent
ai
pushed a commit
that referenced
this pull request
Feb 10, 2024
…pdate missing typedefs (#147) * add missing 'addClean' reporter type definition * add BaseServer 'unauthenticated' event on par with 'authenticated' to allow advanced logging catch ServerClient (unavailable via reporter interface) * add 'unsubscribed' event clientNodeId last arg (that can be either serverNodeId (server-initiated -ch) or clientNodeId (client-initiated -ch) * ClientServerdestroy: allow 'unsubscribed' event handler to retrieve ServerClient by evicting nodeIds / clientIds later, after unsubscribe * fix indent
ai
pushed a commit
that referenced
this pull request
Feb 15, 2024
…pdate missing typedefs (#147) * add missing 'addClean' reporter type definition * add BaseServer 'unauthenticated' event on par with 'authenticated' to allow advanced logging catch ServerClient (unavailable via reporter interface) * add 'unsubscribed' event clientNodeId last arg (that can be either serverNodeId (server-initiated -ch) or clientNodeId (client-initiated -ch) * ClientServerdestroy: allow 'unsubscribed' event handler to retrieve ServerClient by evicting nodeIds / clientIds later, after unsubscribe * fix indent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found that addClean reporter typedef is missing. Fixed.
Also while implementing suitable logging in my app I found out there are some bits missing: