fix(add-sync-map-filter): action filter types and built-in filter (#148)

* fix(add-sync-map-filter): action filter types of resent action * fix(add-sync-map-filter): don’t resend `changed` actions that didn’t pass filter * Update add-sync-map/index.js --------- Co-authored-by: Andrey Sitnik <[email protected]>
logux · Aug 15, 2023 · 90a0712 · 90a0712
1 parent ebc9815
commit 90a0712
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 2 deletions.
diff --git a/add-sync-map/index.d.ts b/add-sync-map/index.d.ts
@@ -1,8 +1,11 @@
 import type {
   LoguxSubscribeAction,
   SyncMapChangeAction,
+  SyncMapChangedAction,
   SyncMapCreateAction,
+  SyncMapCreatedAction,
   SyncMapDeleteAction,
+  SyncMapDeletedAction,
   SyncMapTypes,
   SyncMapValues
 } from '@logux/actions'
@@ -58,7 +61,10 @@ export function NoConflictResolution<
 interface SyncMapActionFilter<Value extends SyncMapValues> {
   (
     ctx: Context,
-    action: SyncMapCreateAction<Value> | SyncMapDeleteAction,
+    action:
+      | SyncMapChangedAction<Value>
+      | SyncMapCreatedAction<Value>
+      | SyncMapDeletedAction,
     meta: ServerMeta
   ): boolean | Promise<boolean>
 }
@@ -82,7 +88,7 @@ interface SyncMapOperations<Value extends SyncMapValues> {
     time: number,
     action: SyncMapChangeAction<Value>,
     meta: ServerMeta
-  ): boolean | Promise<boolean | void> | void 
+  ): boolean | Promise<boolean | void> | void
 
   create?(
     ctx: Context,

diff --git a/add-sync-map/index.js b/add-sync-map/index.js
@@ -44,6 +44,14 @@ function buildFilter(filter) {
         if (action.fields[key] !== filter[key]) return false
       }
     }
+    if (action.type.endsWith('/changed')) {
+      for (let key in filter) {
+        if (
+          key in action.fields &&
+          action.fields[key] !== filter[key]
+        ) return false
+      }
+    }
     return true
   }
 }