modify FACILITY_LABELS,add security/authorization2 and clock2

[TaeRoen]

The FACILITY_LABELS list is not similar to rfc3164 and rfc5424‘s Facility list, it lose repeating option security/authorization and clock. Where i set my facility to local7,it will return me to local5. So, i add security/authorization2 and clock2,make the FACILITY_LABELS list conform to rfc. Thanks.

[karmi]

Hi @TaeRoen, we have found your signature in our records, but it seems like you have signed with a different e-mail than the one used in yout Git commit. Can you please add both of these e-mails into your Github profile (they can be hidden), so we can match your e-mails to your Github profile?

[TaeRoen]

Hi Karel Minarik, This is my email, github user TaeRoen. I'm sorry I signed twice CLA with same email. I have set my github's profile to public email. [email protected] From: Karel Minarik Date: 2016-12-20 12:46 To: logstash-plugins/logstash-output-syslog CC: TaeRoen; Mention Subject: Re: [logstash-plugins/logstash-output-syslog] modify FACILITY_LABELS,add security/authorization2 and clock2 (#34) Hi @TaeRoen, we have found your signature in our records, but it seems like you have signed with a different e-mail than the one used in yout Git commit. Can you please add both of these e-mails into your Github profile (they can be hidden), so we can match your e-mails to your Github profile? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[breml]

Hi @TaeRoen, good catch, thank you.

I asked my self if, we are going to change the labels anyway, we should harmonize the used labes in this plugin with the labels used in logstash-input-syslog. This would inpact daemon, which is called system in the input plugin as well as the two which are added in this PR, because these do not have distinct names for security/authorization and clock. Other than that, there are 3 labels, for which only the upper-/lower-case differs (UUCP, FTP, NTP).

In my opinion these labels should be harmonized, because I think it should be possible to use the logstash-input-syslog together with logstash-output-syslog without the need of additional filters, which adjust the labels. What do you think?

CC: @jordansissel @suyograo

[breml]

Links to the respective sections in the RFC:
https://tools.ietf.org/html/rfc3164#section-4.1.1
https://tools.ietf.org/html/rfc5424#section-6.2.1

[TaeRoen]

@breml Thanks

I just read the logstash-input-syslog‘s code,I agree with your opinion.It should be security/authorization and clock rather than security/authorization2 and clock2.

[breml]

@TaeRoen sorry for let you down on this one for such a long time. I just yesterday opened a the bug logstash-plugins/logstash-input-syslog#37 on logstash-input-plugin to get more attention on this one.
Today I again did some thinking and one way of implementing this one would be to make the facilities and the severities configurable the same was as it is done in logstash-input-plugin (see https://github.com/logstash-plugins/logstash-input-syslog/blob/master/lib/logstash/inputs/syslog.rb#L47). This way we could manage the backwards compatibility while still allow the user to set these values to what ever he likes.

@TaeRoen I hope you don't mind if I reopen this PR until a decision is take, how to go forward with this one? The problem you have pointed out is still valid and therefore should be resolved (even if the way, how we want to handle it, is not yet clear).
@suyograo do you mind to have a look at this PR?

[avinson]

@jsvd @jordansissel @breml @karmi

sorry to be a bother but could we merge this please? it's only a two line change and would fix a major issue.. i don't understand holding this up over an unsigned commit. thanks!

[TaeRoen]

@avinson
sorry to signed CLA before create the pull request,the following URL is my signed Individual Contributor License Agreement.
Individual Contributor License Agreement

[cla-checker-service]

❌ Author of the following commits did not sign a Contributor Agreement:
e7470f8

Please, read and sign the above mentioned agreement if you want to contribute to this project