add github actions workflows + pre-commit hooks #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I expect the pre-commit and actions to be slightly off and need tweaking once or twice before it's the same. |
|
In particular, I suspect that clippy is not running quite the same, but I'm not 100% sure. It's fine for now. |
|
doublify/pre-commit-rust#13 should fix the clippy issue (after updating precommit to use the new version of the hook...) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Runs
cargo check,cargo fmt,cargo test, and clippy on all PRs and commits on master.I also added pre-commit hooks which help prevent bad or non-functional commits. It is technically not required, but will help prevent PRs being blocked by clippy or formatting.