Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated to axum 0.7.1, dropped http-body dependency #21

Merged
merged 7 commits into from
Nov 29, 2023
Merged

Updated to axum 0.7.1, dropped http-body dependency #21

merged 7 commits into from
Nov 29, 2023

Conversation

spigaz
Copy link
Contributor

@spigaz spigaz commented Nov 28, 2023

Hi,

I did my best to update it to support axum 0.7.1.

I also updated the example to axum 0.7.1 and workers 0.0.18.

I executed the tests on chrome, firefox and safari, and tested the example.

I also added .cargo/config.toml
[build]
target = "wasm32-unknown-unknown"

So that it works fine with cargo build and cargo check.

Cheers! Thanks!

@spigaz
Copy link
Contributor Author

spigaz commented Nov 29, 2023

Sorry for two things:

I removed the previous pull request because I didn't knew it automatically updated with new commits on the branch.

I committed by mistake a flag that requires nightly, but its all fixed now, it should be working fine now for stable.

Thanks!

@logankeenan
Copy link
Owner

@spigaz - Thanks for the contribution.

Looks like I'm not running the test CI job on PRs. I just updated that. I'll take a look at the other failing issue too.

@logankeenan logankeenan merged commit 5ad675b into logankeenan:main Nov 29, 2023
@logankeenan
Copy link
Owner

@spigaz - I've released version 0.7.0.

Thank you very much for your contributions!

@spigaz
Copy link
Contributor Author

spigaz commented Nov 29, 2023

Well, I had to do my best to give back, as your lib helped me a lot to get started.

Sorry for the issues on the wrangler.toml, I guessing the file I used as reference wasn't okay, although updated to 0.0.18.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants