Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Worked on JSON serializer helper #66

Merged
merged 2 commits into from
Apr 7, 2024

Conversation

joachimmetz
Copy link
Member

@joachimmetz joachimmetz commented Apr 6, 2024

No description provided.

@joachimmetz joachimmetz added the blocked Work cannot progress until another issue is resolved label Apr 6, 2024
@joachimmetz joachimmetz self-assigned this Apr 6, 2024
Copy link

codecov bot commented Apr 6, 2024

Codecov Report

Attention: Patch coverage is 62.50000% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 83.00%. Comparing base (e5331cf) to head (2f89f59).

❗ Current head 2f89f59 differs from pull request most recent head ff5d5a8. Consider uploading reports for the commit ff5d5a8 to get more accurate results

Files Patch % Lines
acstore/helpers/json_serializer.py 53.84% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #66      +/-   ##
==========================================
- Coverage   83.35%   83.00%   -0.35%     
==========================================
  Files          10       10              
  Lines         853      859       +6     
==========================================
+ Hits          711      713       +2     
- Misses        142      146       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joachimmetz joachimmetz merged commit 15e283f into log2timeline:main Apr 7, 2024
9 checks passed
@joachimmetz joachimmetz deleted the serializer2 branch May 5, 2024 10:57
@joachimmetz joachimmetz removed the blocked Work cannot progress until another issue is resolved label May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant