Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Worked on JSON serializer helper #57

Merged
merged 1 commit into from
Jan 21, 2024
Merged

Conversation

joachimmetz
Copy link
Member

No description provided.

@joachimmetz joachimmetz self-assigned this Jan 21, 2024
Copy link

codecov bot commented Jan 21, 2024

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (240444e) 83.12% compared to head (d6b5991) 83.17%.

Files Patch % Lines
acstore/sqlite_store.py 25.00% 6 Missing ⚠️
acstore/helpers/json_serializer.py 87.87% 4 Missing ⚠️
acstore/interface.py 94.11% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #57      +/-   ##
==========================================
+ Coverage   83.12%   83.17%   +0.04%     
==========================================
  Files           9       10       +1     
  Lines         806      844      +38     
==========================================
+ Hits          670      702      +32     
- Misses        136      142       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joachimmetz joachimmetz merged commit d235757 into log2timeline:main Jan 21, 2024
11 checks passed
@joachimmetz joachimmetz deleted the json1 branch January 21, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant