Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Microsoft.ServiceFabric.* from 7.1.1541 to 7.1.1951 #182

Merged
merged 13 commits into from
Apr 21, 2024

Conversation

abatishchev
Copy link
Collaborator

No description provided.

@abatishchev abatishchev requested a review from loekd as a code owner April 19, 2024 21:41
@loekd
Copy link
Owner

loekd commented Apr 20, 2024

Looks like the build is falling during the install of sf. I'll have to look into that.
It seems like an issue in the MS provided script.

@abatishchev
Copy link
Collaborator Author

abatishchev commented Apr 20, 2024

@loekd I'm trying to debug the error.

First, I found this PowerShell/PowerShell#19833
But then I found a good explanatory of what's going on in here: PowerShell/PowerShell#18530 (comment)

And indeed, the GitHub workflow task runs powershell.exe (PS for Windows) instead of pwsh.exe (PS Core)

@abatishchev
Copy link
Collaborator Author

Can you permitting running workflows to a group of contributors and add me to it?

@abatishchev
Copy link
Collaborator Author

@abatishchev
Copy link
Collaborator Author

Success! It made progress to the next step.

Can you please check why it fails? I wonder why does it need an snk file in the first place?

@loekd
Copy link
Owner

loekd commented Apr 21, 2024

I've been asked to sign the package. I am using a self signed certificate for that. Injecting the password from the environment.

loekd added 2 commits April 21, 2024 19:49
Hardcoded password
Fixed version
@loekd loekd merged commit 6aebf8d into loekd:master Apr 21, 2024
2 checks passed
@abatishchev abatishchev deleted the patch-1 branch April 21, 2024 17:56
@abatishchev
Copy link
Collaborator Author

Yay!!

@loekd
Copy link
Owner

loekd commented Apr 22, 2024

Thanks for all your help @abatishchev !
The new version is live now.

@abatishchev
Copy link
Collaborator Author

Thank you! I'm trying it in my internal project now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants