Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Microsoft.ServiceFabric.Actors from 6.1.1833 to 7.0.1816 #176

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 7, 2023

Bumps Microsoft.ServiceFabric.Actors from 6.1.1833 to 7.0.1816.

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps Microsoft.ServiceFabric.Actors from 6.1.1833 to 7.0.1816.

---
updated-dependencies:
- dependency-name: Microsoft.ServiceFabric.Actors
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot requested a review from loekd as a code owner September 7, 2023 20:50
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Sep 7, 2023
@abatishchev
Copy link
Collaborator

@loekd ping on this, please.

@loekd
Copy link
Owner

loekd commented Sep 25, 2023

The build keeps failing. Could be that the runner doesn't have the latest bits installed. I've seen that before unfortunately.

Bumps Microsoft.ServiceFabric.Actors from 6.1.1833 to 7.0.1816.

---
updated-dependencies:
- dependency-name: Microsoft.ServiceFabric.Actors
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/nuget/Microsoft.ServiceFabric.Actors-7.0.1816 branch from d4abcad to 4243012 Compare September 25, 2023 16:13
@abatishchev
Copy link
Collaborator

Which region the runner is deployed to? I can look it up in the rollout schedule.

And do you want to deploy to a Canary region instead? It'd be less stable but if the primary purpose is to validate the build then it should be ok.

@loekd
Copy link
Owner

loekd commented Sep 25, 2023

I'm willing to give a canary region a try. I will need a little guidance to do that.

I don't know which region the hosted runner uses. Thought I had no insights or influence on that. The pipeline is defined here.

@abatishchev
Copy link
Collaborator

Ah, I see. I though you're running an SF cluster which didn't received the updated version yet. But the pipeline you provided a link to looks like as just a build. Can you explain a bit more what a GitHub Runner does? To be honest, I'm not familiar with this technology, yet.

@loekd
Copy link
Owner

loekd commented Sep 25, 2023

It's an agent/daemon that runs on an Azure VM. You can run built-in tasks on it, Same thing as a hosted agent in Azure DevOps. Here I use it to build my binaries and run unit tests. The unit tests depend on the SF SDK to be present.
This error message Unhandled exception. System.IO.FileNotFoundException: Could not load file or assembly 'C:\Program Files\Microsoft Service Fabric\bin\Fabric\Fabric.Code\NS_10\Microsoft.ServiceFabric.Data.Impl.dll'. The system cannot find the path specified.

From the build output here makes me think that the SDK is not present. There is a folder named 'C:\Program Files\Microsoft Service Fabric\bin\Fabric\Fabric.Code\NS_9 but not NS_10.

@yashagarwal23
Copy link

yashagarwal23 commented Sep 26, 2023

It seems the build pipeline is using this runner image - runner-images/images/win/Windows2022-Readme.md at win22/20230918.1 · actions/runner-images (github.com)

Here I see, service fabric SDK version available is 9.1.1436. I assume the SF runtime is also of the same version.
For Actors nuget v7.0.1816, you must have SF 10.0.1816 or higher version installed.

You would probably need to wait for the SF 10 version to be available along with the runner image or you can add a step in the pipeline that installs the latest version.

@abatishchev
Copy link
Collaborator

:shipit:

@loekd loekd merged commit c393276 into master Sep 26, 2023
4 checks passed
@loekd loekd deleted the dependabot/nuget/Microsoft.ServiceFabric.Actors-7.0.1816 branch September 26, 2023 16:38
@loekd
Copy link
Owner

loekd commented Sep 26, 2023

Thanks @abatishchev and @yashagarwal23

I've added the setup code to the pipeline. Hope it's a temporary fix, otherwise I'll end up having to replace the installer for every future SF version upgrade.
Build is running, fingers crossed.

Still to investigate:
My codespaces version fails to run the tests. This is an Ubuntu based devcontainer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants