Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing issue with Eigen in Ubuntu Jammy on ARM #378

Merged
merged 3 commits into from
Sep 19, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions fuse_constraints/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,15 @@ else()
add_compile_options(-Wall -Werror)
endif()

# On ARM, the use of Eigen 3.4 with g++11 (both the versions in Jammy) causes a warning, which in turn causes
# the build to fail. Details are here: https://gitlab.com/libeigen/eigen/-/issues/2326. We can suppress the warning
# for ARM builds here.
if(Eigen3_VERSION VERSION_EQUAL 3.4 AND
CMAKE_CXX_COMPILER_VERSION VERSION_GREATER 11.0 AND
CMAKE_LIBRARY_ARCHITECTURE STREQUAL "aarch64-linux-gnu")
add_compile_options(-Wno-class-memaccess)
endif()

# fuse_constraints library
add_library(${PROJECT_NAME}
src/absolute_constraint.cpp
Expand Down
9 changes: 9 additions & 0 deletions fuse_core/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,15 @@ catkin_package(
###########
add_compile_options(-Wall -Werror)

# On ARM, the use of Eigen 3.4 with g++11 (both the versions in Jammy) causes a warning, which in turn causes
# the build to fail. Details are here: https://gitlab.com/libeigen/eigen/-/issues/2326. We can suppress the warning
# for ARM builds here.
if(Eigen3_VERSION VERSION_EQUAL 3.4 AND
CMAKE_CXX_COMPILER_VERSION VERSION_GREATER 11.0 AND
CMAKE_LIBRARY_ARCHITECTURE STREQUAL "aarch64-linux-gnu")
add_compile_options(-Wno-class-memaccess)
endif()

## fuse_core library
add_library(${PROJECT_NAME}
src/async_motion_model.cpp
Expand Down
9 changes: 9 additions & 0 deletions fuse_models/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,15 @@ roslint_cpp()
###########
add_compile_options(-Wall -Werror)

# On ARM, the use of Eigen 3.4 with g++11 (both the versions in Jammy) causes a warning, which in turn causes
# the build to fail. Details are here: https://gitlab.com/libeigen/eigen/-/issues/2326. We can suppress the warning
# for ARM builds here.
if(Eigen3_VERSION VERSION_EQUAL 3.4 AND
CMAKE_CXX_COMPILER_VERSION VERSION_GREATER 11.0 AND
CMAKE_LIBRARY_ARCHITECTURE STREQUAL "aarch64-linux-gnu")
add_compile_options(-Wno-class-memaccess)
endif()

## Declare a C++ library
add_library(${PROJECT_NAME}
src/acceleration_2d.cpp
Expand Down
14 changes: 14 additions & 0 deletions fuse_publishers/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,20 @@ catkin_package(
###########
add_compile_options(-Wall -Werror)

# On ARM, the use of Eigen 3.4 with g++11 (both the versions in Jammy) causes a warning, which in turn causes
# the build to fail. Details are here: https://gitlab.com/libeigen/eigen/-/issues/2326. We can suppress the warning
# for ARM builds here. However, this package does not depend directly upon Eigen, but includes headers from other
# packages that do. So to prevent the error, we need to find Eigen and then check the version.
if(CMAKE_CXX_COMPILER_VERSION VERSION_GREATER 11.0 AND
CMAKE_LIBRARY_ARCHITECTURE STREQUAL "aarch64-linux-gnu")

find_package(Eigen3)

if(Eigen3_FOUND AND Eigen3_VERSION VERSION_EQUAL 3.4)
add_compile_options(-Wno-class-memaccess)
endif()
endif()

# fuse_publishers library
add_library(${PROJECT_NAME}
src/path_2d_publisher.cpp
Expand Down
14 changes: 14 additions & 0 deletions fuse_viz/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,20 @@ add_definitions(-DQT_NO_KEYWORDS)
###########
add_compile_options(-Wall -Werror)

# On ARM, the use of Eigen 3.4 with g++11 (both the versions in Jammy) causes a warning, which in turn causes
# the build to fail. Details are here: https://gitlab.com/libeigen/eigen/-/issues/2326. We can suppress the warning
# for ARM builds here. However, this package does not depend directly upon Eigen, but includes headers from other
# packages that do. So to prevent the error, we need to find Eigen and then check the version.
if(CMAKE_CXX_COMPILER_VERSION VERSION_GREATER 11.0 AND
CMAKE_LIBRARY_ARCHITECTURE STREQUAL "aarch64-linux-gnu")

find_package(Eigen3)

if(Eigen3_FOUND AND Eigen3_VERSION VERSION_EQUAL 3.4)
add_compile_options(-Wno-class-memaccess)
endif()
endif()

catkin_package(
INCLUDE_DIRS include
LIBRARIES ${PROJECT_NAME}
Expand Down
Loading