Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve app name validation #853

Merged
merged 6 commits into from
Oct 20, 2024
Merged

Conversation

kaplanelad
Copy link
Contributor

Following the finding in fuzzy generator template findings, I took the cargo validation and moved it to our validation

@kaplanelad kaplanelad self-assigned this Oct 15, 2024
@@ -48,6 +47,7 @@ cfg-if = "1.0.0"
dunce = { version = "1.0.4" }
strum = { version = "0.26", features = ["derive"] }
colored = "2"
unicode-xid = "0.2.6"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think we can drop checking for unicode by the fact that we don't allow unicode in app name.
its reasonable to just say app names are alphanumeric (ASCII)

@kaplanelad kaplanelad merged commit be8cf75 into master Oct 20, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants