-
Notifications
You must be signed in to change notification settings - Fork 989
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a port pool manager to restrict client ports #134
base: master
Are you sure you want to change the base?
Conversation
ac989ad
to
dbba723
Compare
ba01939
to
5a3a009
Compare
hi @defunctzombie Merging this will be amazing! |
@defunctzombie could you please merge this one? We can configure firewall after that |
I don't actively work on this project anymore. @TheBoroer does some upkeep so its up to him. |
5a3a009
to
ac989ad
Compare
ac989ad
to
3c06736
Compare
this is very important |
so please say int on front readme to avoid people thinking this project is not dead anymore.... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good.
Sorry I've been mia, imma check this out early next week. If its good to go, I'll ping @defunctzombie to give me access to merge it in and push a new version to npm |
Hope to see this feature in soon, it would save from opening a huge amount of ports in the firewall |
I'm using this on my server and something unique happened. I can't say how to recreate this because I'm not able to reproduce myself, but sometimes one URL gives me another client. Let's say I have client1 and client2; sometimes, when I access client1 I'm actually accessing client2, and only normalizes when I restart the server and make the connection again. Do you think this port manager may be the cause? |
this PR to avoid the dynamic attribution of port by
net.createServer()
but rather by a range specified on the server command line. An internal pool is maintained to distribute ports