Bugfix: InterruptContext used non-ISR function in drop (#78)

`freertos_rs_isr_yield()` used `portYIELD()` instead of `portYIELD_FROM_ISR()`.
lobaro · Oct 3, 2024 · 953b580 · 953b580
1 parent 59b0a36
commit 953b580
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 7 deletions.
diff --git a/freertos-rust/src/freertos/shim.c b/freertos-rust/src/freertos/shim.c
@@ -277,8 +277,8 @@ UBaseType_t freertos_rs_queue_messages_waiting(QueueHandle_t queue) {
 	return uxQueueMessagesWaiting( queue );
 }
 
-void freertos_rs_isr_yield() {
-	portYIELD();
+void freertos_rs_isr_yield(BaseType_t xHigherPriorityTaskWoken) {
+	portYIELD_FROM_ISR(xHigherPriorityTaskWoken);
 }
 
 TickType_t freertos_rs_max_wait() {

diff --git a/freertos-rust/src/isr.rs b/freertos-rust/src/isr.rs
@@ -27,10 +27,8 @@ impl InterruptContext {
 
 impl Drop for InterruptContext {
     fn drop(&mut self) {
-        if self.x_higher_priority_task_woken == 1 {
-            unsafe {
-                freertos_rs_isr_yield();
-            }
+        unsafe {
+            freertos_rs_isr_yield(self.x_higher_priority_task_woken);
         }
     }
 }
diff --git a/freertos-rust/src/shim.rs b/freertos-rust/src/shim.rs
@@ -81,7 +81,7 @@ extern "C" {
         item: FreeRtosVoidPtr,
         xHigherPriorityTaskWoken: FreeRtosBaseTypeMutPtr,
     ) -> FreeRtosUBaseType;
-    pub fn freertos_rs_isr_yield();
+    pub fn freertos_rs_isr_yield(xHigherPriorityTaskWoken: FreeRtosBaseType);
 
     pub fn freertos_rs_task_notify_take(clear_count: u8, wait: FreeRtosTickType) -> u32;
     pub fn freertos_rs_task_notify_wait(