Skip to content
Lint

CAKE-63: Cleanup rkyv dependency management and cleanup dataviews #200

Sign in to view logs

CAKE-63: Cleanup rkyv dependency management and cleanup dataviews

CAKE-63: Cleanup rkyv dependency management and cleanup dataviews #200

GitHub Actions / clippy succeeded Dec 31, 2023 in 0s

clippy

37 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 37
Note 0
Help 0

Versions

  • rustc 1.77.0-nightly (3cdd004e5 2023-12-29)
  • cargo 1.77.0-nightly (ac6bbb332 2023-12-26)
  • clippy 0.1.77 (3cdd004 2023-12-29)

Annotations

Check warning on line 586 in datacake-eventual-consistency/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

use of `default` to create a unit struct 

warning: use of `default` to create a unit struct
   --> datacake-eventual-consistency/src/lib.rs:586:38
    |
586 |             _marker: PhantomData::<S>::default(),
    |                                      ^^^^^^^^^^^ help: remove this call to `default`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

Check warning on line 529 in datacake-eventual-consistency/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

use of `default` to create a unit struct 

warning: use of `default` to create a unit struct
   --> datacake-eventual-consistency/src/lib.rs:529:38
    |
529 |             _marker: PhantomData::<S>::default(),
    |                                      ^^^^^^^^^^^ help: remove this call to `default`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

Check warning on line 469 in datacake-eventual-consistency/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

use of `default` to create a unit struct 

warning: use of `default` to create a unit struct
   --> datacake-eventual-consistency/src/lib.rs:469:38
    |
469 |             _marker: PhantomData::<S>::default(),
    |                                      ^^^^^^^^^^^ help: remove this call to `default`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

Check warning on line 404 in datacake-eventual-consistency/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

use of `default` to create a unit struct 

warning: use of `default` to create a unit struct
   --> datacake-eventual-consistency/src/lib.rs:404:38
    |
404 |             _marker: PhantomData::<S>::default(),
    |                                      ^^^^^^^^^^^ help: remove this call to `default`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

Check warning on line 274 in datacake-eventual-consistency/src/rpc/services/replication_impl.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

use of `default` to create a unit struct 

warning: use of `default` to create a unit struct
   --> datacake-eventual-consistency/src/rpc/services/replication_impl.rs:274:49
    |
274 |                 _marker: PhantomData::<MemStore>::default(),
    |                                                 ^^^^^^^^^^^ help: remove this call to `default`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

Check warning on line 228 in datacake-eventual-consistency/src/rpc/services/replication_impl.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

use of `default` to create a unit struct 

warning: use of `default` to create a unit struct
   --> datacake-eventual-consistency/src/rpc/services/replication_impl.rs:228:49
    |
228 |                 _marker: PhantomData::<MemStore>::default(),
    |                                                 ^^^^^^^^^^^ help: remove this call to `default`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

Check warning on line 233 in datacake-eventual-consistency/src/rpc/services/consistency_impl.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

use of `default` to create a unit struct 

warning: use of `default` to create a unit struct
   --> datacake-eventual-consistency/src/rpc/services/consistency_impl.rs:233:42
    |
233 |                 _marker: PhantomData::<S>::default(),
    |                                          ^^^^^^^^^^^ help: remove this call to `default`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

Check warning on line 219 in datacake-eventual-consistency/src/rpc/services/consistency_impl.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

use of `default` to create a unit struct 

warning: use of `default` to create a unit struct
   --> datacake-eventual-consistency/src/rpc/services/consistency_impl.rs:219:42
    |
219 |                 _marker: PhantomData::<S>::default(),
    |                                          ^^^^^^^^^^^ help: remove this call to `default`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

Check warning on line 188 in datacake-eventual-consistency/src/rpc/services/consistency_impl.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

use of `default` to create a unit struct 

warning: use of `default` to create a unit struct
   --> datacake-eventual-consistency/src/rpc/services/consistency_impl.rs:188:38
    |
188 |             _marker: PhantomData::<S>::default(),
    |                                      ^^^^^^^^^^^ help: remove this call to `default`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

Check warning on line 158 in datacake-eventual-consistency/src/rpc/services/consistency_impl.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

use of `default` to create a unit struct 

warning: use of `default` to create a unit struct
   --> datacake-eventual-consistency/src/rpc/services/consistency_impl.rs:158:38
    |
158 |             _marker: PhantomData::<S>::default(),
    |                                      ^^^^^^^^^^^ help: remove this call to `default`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

Check warning on line 128 in datacake-eventual-consistency/src/rpc/services/consistency_impl.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

use of `default` to create a unit struct 

warning: use of `default` to create a unit struct
   --> datacake-eventual-consistency/src/rpc/services/consistency_impl.rs:128:38
    |
128 |             _marker: PhantomData::<S>::default(),
    |                                      ^^^^^^^^^^^ help: remove this call to `default`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

Check warning on line 96 in datacake-eventual-consistency/src/rpc/services/consistency_impl.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

use of `default` to create a unit struct 

warning: use of `default` to create a unit struct
  --> datacake-eventual-consistency/src/rpc/services/consistency_impl.rs:96:38
   |
96 |             _marker: PhantomData::<S>::default(),
   |                                      ^^^^^^^^^^^ help: remove this call to `default`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

Check warning on line 513 in datacake-eventual-consistency/src/replication/poller.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

use of `default` to create a unit struct 

warning: use of `default` to create a unit struct
   --> datacake-eventual-consistency/src/replication/poller.rs:513:34
    |
513 |         _marker: PhantomData::<S>::default(),
    |                                  ^^^^^^^^^^^ help: remove this call to `default`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

Check warning on line 504 in datacake-eventual-consistency/src/replication/poller.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

use of `default` to create a unit struct 

warning: use of `default` to create a unit struct
   --> datacake-eventual-consistency/src/replication/poller.rs:504:38
    |
504 |             _marker: PhantomData::<S>::default(),
    |                                      ^^^^^^^^^^^ help: remove this call to `default`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

Check warning on line 471 in datacake-eventual-consistency/src/replication/poller.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

use of `default` to create a unit struct 

warning: use of `default` to create a unit struct
   --> datacake-eventual-consistency/src/replication/poller.rs:471:38
    |
471 |             _marker: PhantomData::<S>::default(),
    |                                      ^^^^^^^^^^^ help: remove this call to `default`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

Check warning on line 254 in datacake-eventual-consistency/src/keyspace/group.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

use of `default` to create a unit struct 

warning: use of `default` to create a unit struct
   --> datacake-eventual-consistency/src/keyspace/group.rs:254:69
    |
254 |             if let Err(e) = state.send(PurgeDeletes(PhantomData::<S>::default())).await {
    |                                                                     ^^^^^^^^^^^ help: remove this call to `default`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
    = note: `#[warn(clippy::default_constructed_unit_structs)]` on by default

Check warning on line 151 in datacake-node/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

use of `default` to create a unit struct 

warning: use of `default` to create a unit struct
   --> datacake-node/src/lib.rs:151:43
    |
151 |             node_selector: DCAwareSelector::default(),
    |                                           ^^^^^^^^^^^ help: remove this call to `default`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

Check warning on line 544 in datacake-node/src/nodes_selector.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

use of `default` to create a unit struct 

warning: use of `default` to create a unit struct
   --> datacake-node/src/nodes_selector.rs:544:43
    |
544 |         let mut selector = DCAwareSelector::default();
    |                                           ^^^^^^^^^^^ help: remove this call to `default`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
    = note: `#[warn(clippy::default_constructed_unit_structs)]` on by default

Check warning on line 29 in datacake-rpc/src/rkyv_tooling/scratch.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this `impl` can be derived 

warning: this `impl` can be derived
  --> datacake-rpc/src/rkyv_tooling/scratch.rs:21:1
   |
21 | / impl Default for LazyScratch {
22 | |     fn default() -> Self {
23 | |         Self {
24 | |             stack_scratch: StackScratch::default(),
...  |
28 | |     }
29 | | }
   | |_^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls
   = note: `#[warn(clippy::derivable_impls)]` on by default
   = help: remove the manual implementation...
help: ...and instead derive it
   |
15 + #[derive(Default)]
16 | pub struct LazyScratch {
   |

Check warning on line 119 in datacake-rpc/src/handler.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

use of `default` to create a unit struct 

warning: use of `default` to create a unit struct
   --> datacake-rpc/src/handler.rs:119:37
    |
119 |             _msg: PhantomData::<Msg>::default(),
    |                                     ^^^^^^^^^^^ help: remove this call to `default`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
    = note: `#[warn(clippy::default_constructed_unit_structs)]` on by default

Check warning on line 586 in datacake-eventual-consistency/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

use of `default` to create a unit struct 

warning: use of `default` to create a unit struct
   --> datacake-eventual-consistency/src/lib.rs:586:38
    |
586 |             _marker: PhantomData::<S>::default(),
    |                                      ^^^^^^^^^^^ help: remove this call to `default`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

Check warning on line 529 in datacake-eventual-consistency/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

use of `default` to create a unit struct 

warning: use of `default` to create a unit struct
   --> datacake-eventual-consistency/src/lib.rs:529:38
    |
529 |             _marker: PhantomData::<S>::default(),
    |                                      ^^^^^^^^^^^ help: remove this call to `default`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

Check warning on line 469 in datacake-eventual-consistency/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

use of `default` to create a unit struct 

warning: use of `default` to create a unit struct
   --> datacake-eventual-consistency/src/lib.rs:469:38
    |
469 |             _marker: PhantomData::<S>::default(),
    |                                      ^^^^^^^^^^^ help: remove this call to `default`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

Check warning on line 404 in datacake-eventual-consistency/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

use of `default` to create a unit struct 

warning: use of `default` to create a unit struct
   --> datacake-eventual-consistency/src/lib.rs:404:38
    |
404 |             _marker: PhantomData::<S>::default(),
    |                                      ^^^^^^^^^^^ help: remove this call to `default`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

Check warning on line 233 in datacake-eventual-consistency/src/rpc/services/consistency_impl.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

use of `default` to create a unit struct 

warning: use of `default` to create a unit struct
   --> datacake-eventual-consistency/src/rpc/services/consistency_impl.rs:233:42
    |
233 |                 _marker: PhantomData::<S>::default(),
    |                                          ^^^^^^^^^^^ help: remove this call to `default`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
View more details on GitHub Actions