Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use explicit package list and ensure it is tested in CI #232

Merged
merged 2 commits into from
Jun 4, 2024

Conversation

wshanks
Copy link
Collaborator

@wshanks wshanks commented Jun 3, 2024

  • In pyproject.toml, use an explicit package list instead of using the find directive.

  • In GitHub Actions workflow, do not use an editable install since that implicitly includes all modules below uncertainties/ and we want to make sure we test the package in its installed form.

* In `pyproject.toml`, use an explicit package list instead of using the
`find` directive.

* In GitHub Actions workflow, do not use an editable install since that
  implicitly includes all modules below `uncertainties/` and we want to
make sure we test the package in its installed form.
@wshanks wshanks mentioned this pull request Jun 3, 2024
Copy link

codecov bot commented Jun 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.29%. Comparing base (3c3853d) to head (d0c0ee9).

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #232       +/-   ##
===========================================
- Coverage   95.74%   48.29%   -47.46%     
===========================================
  Files          12       12               
  Lines        1903     1903               
===========================================
- Hits         1822      919      -903     
- Misses         81      984      +903     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wshanks
Copy link
Collaborator Author

wshanks commented Jun 3, 2024

I tested this in my fork and it failed with the old way that tool.setuptools.packages.find was formatted. I thought I would need to set PYTHONSAFEPATH or use pytest's import-mode to make sure that the uncertainties in the working directory was not still used instead of the installed one, but I saw the unumpy import error without those settings, so I did not include them here.

Copy link
Member

@newville newville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@newville newville merged commit e3426fd into lmfit:master Jun 4, 2024
17 of 18 checks passed
@wshanks wshanks deleted the package-testing branch June 4, 2024 03:49
@wshanks
Copy link
Collaborator Author

wshanks commented Jun 4, 2024

Hmm, it looks like this caused the way we have coverage set up not to count the coverage of the main package's code. I will look into getting that counted while still testing the installed package. Anyone else is welcome to look into it as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants