Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tune scan #49

Open
wants to merge 29 commits into
base: master
Choose a base branch
from
Open

Tune scan #49

wants to merge 29 commits into from

Conversation

linahv
Copy link
Collaborator

@linahv linahv commented Oct 5, 2023

Fit_tune function:

  • documentation description
  • allows different quadrupole families to be used (N>2) with different array lengths
  • test function implemented and tested

Lina Hoummi and others added 22 commits September 26, 2023 11:33
tune_scan function description added
daa01d9
corrected
2cd91c1
@simoneliuzzo
indents
09a77c8
@simoneliuzzo
minors for help
7becaaf
remove error message. Fix conflict.
1ed4e9f
added doc. Removed unexplained inputs of quadrupoles.
1a5db63
revert changes
c596445
revert changes
025d3de
corrected conflicts
21640de
@linahv
Merge branch 'master' into tune_scan
0d783a9
fit_tune documentation
55013c6
added description of fit_tune
b41ef80
changes in fit_tune
71410bb
testing in progress
87f4b27
quadrupole input now allows N number of families, each with different…
db8f62d 
… length array
test functions for tune and chroma correction
12ce744
typo
1faa6b4
succesful test
6c3935d
@linahv
Merge branch 'master' into tune_scan
2d18041
updated documentation
2a4eb29
Merge branch 'tune_scan' of https://github.com/lmalina/pySC into tune…
55c699b 
…_scan
removed the function tune
3eb4a1b
lmalina
lmalina requested changes Oct 10, 2023
View reviewed changes
Copy link
Owner

@lmalina lmalina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, I went through the code and made only a couple of comments. It is refreshing to see a test;-)

pySC/correction/tune.py Outdated Show resolved Hide resolved
tests/test_tune_chroma.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmalina lmalina lmalina requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@linahv @lmalina @simoneliuzzo