Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chroma #43

Merged
merged 20 commits into from
Jan 24, 2024
Merged

Chroma #43

merged 20 commits into from
Jan 24, 2024

Conversation

linahv
Copy link
Collaborator

@linahv linahv commented Sep 26, 2023

Two things:

  • Unexpected optional quadrupole inputs in the fit_chroma. Quadrupole indexes and a variation of their strengths could be implemented in the SC structure prior to chromaticity correction. The returned lattice would include said changes in quadrupolar strengths.
  • Documentation related: added a description according to SClocoLib. Added a line in the /doc/modules/correction.srt to create a section on Chromaticity. Let me know if another outline was planned.

Function remains to be tested.

@linahv
Copy link
Collaborator Author

linahv commented Sep 27, 2023

Input ordinates can have different lengths.

Testing successful with the principle of the fitting and optimiser. Please verify, I got an error trying to get the end chromaticity of the resulting SC instance.

@linahv
Copy link
Collaborator Author

linahv commented Sep 28, 2023

Test passed:

  • changed atlinopt calls to SC.RING.get_chrom()
  • removed the two lines to set the sextupole strengths since the ring is updated within the optimiser
  • Sextupole family arrays can have different lengths

@lmalina lmalina merged commit c382cbc into master Jan 24, 2024
18 checks passed
@lmalina lmalina deleted the chroma branch January 24, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants