Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AMDGPU][libc] Re-enable batching to keep up #340

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

jplehr
Copy link
Contributor

@jplehr jplehr commented Dec 12, 2024

The current config is unable to keep up with the load on that particular bot, meaning that the build queue filled-up and was at several hours. This reverts the introduced "neverCollapse" and does allow collapsing of build requests.

The current config is unable to keep up with the load on that particular
bot, meaning that the build queue filled-up and was at several hours.
This reverts the introduced "neverCollapse" and does allow collapsing of
build requests.
@jplehr jplehr marked this pull request as ready for review December 12, 2024 20:21
@jplehr jplehr merged commit 6e9ccdb into llvm:main Dec 12, 2024
2 checks passed
@DavidSpickett
Copy link
Contributor

FYI, Linaro's longer running bots also had this issue even with collapsing enabled. If this happens to you, there is a further step you can take - #266.

I think you would need to add clean to OpenMPBuilder and then it should "just work". If your build steps are already being ccached, it's not much extra overhead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants