Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libc: make new bootstrap builder a dup of runtimes #332

Merged
merged 3 commits into from
Dec 9, 2024

Conversation

nickdesaulniers
Copy link
Member

@nickdesaulniers nickdesaulniers commented Dec 4, 2024

Before renaming the existing debian-dbg-runtimes-build to
debian-dbg-bootstrap-build, make sure that the new name will be recognized so
that there's no downtime of CI coverage due to renaming the buildbot.

Also remove llvm from the explicit project list; that's not necessary (or may have
been for old hdrgen which has been removed).

Link: #325 (comment)

Before renaming the existing debian-dbg-runtimes-build to
debian-dbg-bootstrap-build, make sure that the new name will be recognized so
that there's no downtime of CI coverage due to renaming the buildbot.

Link: llvm#325 (comment)
@nickdesaulniers
Copy link
Member Author

Marking as draft. I can copy the existing sources to a newly named dir on the bot, then update 2 more files to just create the new worker (IIUC).

@nickdesaulniers nickdesaulniers marked this pull request as draft December 4, 2024 22:05
…bg-runtimes-build

I have cloned the libc-x86_64-debian-dbg-runtimes-build dir on the buildbot to
libc-x86_64-debian-dbg-bootstrap-build and removed the build dir's contents.
@nickdesaulniers
Copy link
Member Author

Ok, I broke this up into distinct patches which are perhaps easier to review individually (will squash when merging though).

This PR should convert the existing buildbot IIUC.

@nickdesaulniers nickdesaulniers marked this pull request as ready for review December 4, 2024 22:14
@nickdesaulniers
Copy link
Member Author

nickdesaulniers commented Dec 4, 2024

Might want to drop that last commit. Reading the zorg sources trying to make sense of what depends_on_projects implies.

EDIT: done

@nickdesaulniers
Copy link
Member Author

ping for review

@nickdesaulniers nickdesaulniers merged commit 5c14bef into llvm:main Dec 9, 2024
2 checks passed
@nickdesaulniers nickdesaulniers deleted the bootstrap branch December 9, 2024 23:18
@nickdesaulniers
Copy link
Member Author

Hi @gkistanova . I was suspecting that this PR would have changed the "libc-x86_64-debian-dbg-runtimes-build" builder to be "libc-x86_64-debian-dbg-bootstrap-build", but a day later the builder still has not changed. Is there something on your end that needs to explicitly be reset? Or is there something else I need to do?

I've read through https://llvm.org/docs/HowToAddABuilder.html#steps-to-add-builder-to-llvm-buildbot, but I don't see what I'm missing.

@DavidSpickett
Copy link
Contributor

I think you are at:

  1. Send the buildbot-worker access name and the access password directly to Galina Kistanova, and wait until she lets you know that your changes are applied and buildmaster is reconfigured.

But just the latter part, given that the worker is already setup.

Changes to llvm-zorg are not automatically applied, at least for the "normal" master which is the one your specific bot is connecting to. Staging might be updated more often, but that's just my impression.

When the changes are applied, this bot name will likely still be in the results but you'll see new builds under the new name.

@DavidSpickett
Copy link
Contributor

There is certainly room there for an abridged version of adding a worker as "making a change".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants