-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libc: make new bootstrap builder a dup of runtimes #332
Conversation
Before renaming the existing debian-dbg-runtimes-build to debian-dbg-bootstrap-build, make sure that the new name will be recognized so that there's no downtime of CI coverage due to renaming the buildbot. Link: llvm#325 (comment)
Marking as draft. I can copy the existing sources to a newly named dir on the bot, then update 2 more files to just create the new worker (IIUC). |
…bg-runtimes-build I have cloned the libc-x86_64-debian-dbg-runtimes-build dir on the buildbot to libc-x86_64-debian-dbg-bootstrap-build and removed the build dir's contents.
0e68f3c
to
8aae619
Compare
Ok, I broke this up into distinct patches which are perhaps easier to review individually (will squash when merging though). This PR should convert the existing buildbot IIUC. |
Might want to drop that last commit. Reading the zorg sources trying to make sense of what EDIT: done |
8aae619
to
983da19
Compare
ping for review |
Hi @gkistanova . I was suspecting that this PR would have changed the "libc-x86_64-debian-dbg-runtimes-build" builder to be "libc-x86_64-debian-dbg-bootstrap-build", but a day later the builder still has not changed. Is there something on your end that needs to explicitly be reset? Or is there something else I need to do? I've read through https://llvm.org/docs/HowToAddABuilder.html#steps-to-add-builder-to-llvm-buildbot, but I don't see what I'm missing. |
I think you are at:
But just the latter part, given that the worker is already setup. Changes to llvm-zorg are not automatically applied, at least for the "normal" master which is the one your specific bot is connecting to. Staging might be updated more often, but that's just my impression. When the changes are applied, this bot name will likely still be in the results but you'll see new builds under the new name. |
There is certainly room there for an abridged version of adding a worker as "making a change". |
Before renaming the existing debian-dbg-runtimes-build to
debian-dbg-bootstrap-build, make sure that the new name will be recognized so
that there's no downtime of CI coverage due to renaming the buildbot.
Also remove llvm from the explicit project list; that's not necessary (or may have
been for old hdrgen which has been removed).
Link: #325 (comment)