Rename BUILDMASTER_TEST to BUILDBOT_TEST #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BUILDBOT_TEST is sufficiently descriptive (after all, 'buildbot' is the package name and the name of the binary invoked to create a buildmaster) and it's possible upstream may later remove the buildmaster terminology <buildbot/buildbot#5382> or alternatively we might move away from it downstream. As such, it seems prudent to use a name that would be unaffected.
This was referenced Nov 10, 2024
Merged
DavidSpickett
approved these changes
Nov 12, 2024
No, I added it in #289 and there shouldn't be any users as it's only just landed and the docs didn't land yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BUILDBOT_TEST is sufficiently descriptive (after all, 'buildbot' is the package name and the name of the binary invoked to create a buildmaster) and it's possible upstream may later remove the buildmaster terminology buildbot/buildbot#5382 or alternatively we might move away from it downstream. As such, it seems prudent to use a name that would be unaffected.
This came partially from discussion at llvm/llvm-project#115024 - I figure tweaking the name is a lot easier now, before it's fully documented/advertised and part of people's workflows, than later.