Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes CMake configuration failures related with Windows-style/mixed path. #300

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

vvereschaka
Copy link
Contributor

@vvereschaka vvereschaka commented Nov 8, 2024

Fixes syntax errors in cmake code when passing Windows-style path as a string variable during the cmake configuration, such as CMAKE_C_COMPILER=c:\buildbot\as-builder-10\lldb-x-aarch64/build/bin/clang.exe, when running lldb-remote-linux-win builder.

Error:
Invalid character escape '\b'.

To fix, use ':PATH' var type suffix for the passing variables that contain the path values.

…ath.

Fixes syntax errors in cmake code when passing Windows-style path as
a string variable during the cmake configuration, such as

    CMAKE_C_COMPULER=c:\buildbot\as-builder-10\lldb-x-aarch64/build/bin/clang.exe

To fix, use ':PATH' var type suffix for the passing variables that contain the path values.
@vvereschaka vvereschaka self-assigned this Nov 8, 2024
@vvereschaka
Copy link
Contributor Author

The detailed log for the record - https://lab.llvm.org/staging/#/builders/197/builds/4/steps/12/logs/stdio

-- The C compiler identification is Clang 20.0.0
-- Configuring incomplete, errors occurred!
See also "C:/buildbot/as-builder-10/lldb-x-aarch64/build-lldb-server/CMakeFiles/CMakeOutput.log".
CMake Error at C:/buildbot/as-builder-10/lldb-x-aarch64/build-lldb-server/CMakeFiles/3.25.1/CMakeCCompiler.cmake:1 (set):
  Syntax error in cmake code at
    C:/buildbot/as-builder-10/lldb-x-aarch64/build-lldb-server/CMakeFiles/3.25.1/CMakeCCompiler.cmake:1
  when parsing string
    c:\buildbot\as-builder-10\lldb-x-aarch64/build/bin/clang.exe
  Invalid character escape '\b'.
Call Stack (most recent call first):
  CMakeLists.txt:47 (project)

Copy link
Contributor

@gkistanova gkistanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@vvereschaka vvereschaka merged commit de862c7 into llvm:main Nov 8, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants