Skip to content

Commit

Permalink
Do not create build requests for workers if offline longer than 30 mi…
Browse files Browse the repository at this point in the history 
…nutes.
  • Loading branch information
@gkistanova
gkistanova committed Nov 20, 2024
1 parent ae8e5b0 commit 618344c
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions buildbot/osuosl/master/master.cfg
View file
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,8 @@ c['workers'] = config.workers.get_all()

c['protocols'] = {'pb': {'port': "tcp:9990:interface=127.0.0.1" if test_mode else 9990}}

c['ignoreOfflineWorkersTimeout'] = 30 # minutes.

####### CHANGESOURCES

##from buildbot.changes.pb import PBChangeSource
Expand Down

3 comments on commit 618344c

@DavidSpickett
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asb This seems to have broken the pre-commit testing you added:

Run cd buildbot/osuosl/master
Configuration Errors:
  Unknown BuildmasterConfig key ignoreOfflineWorkersTimeout

Is there a mismatch between Buildbot versions that llvm uses and that the pre-commit downloads?

@asb
Copy link
Contributor

@asb asb commented on 618344c Nov 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sadly LLVM's buildbot seems to be deploying a forked version (which is why the deployed buildbot wasn't impacted by the issue with long step names, that I fixed in #293). I think my questions about access to the version that is deployed were missed, but I've submitted a PR that works around this problem for now and raises the question again #323

@nickdesaulniers
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is blocking some changes I'm trying to make in #325.

Please sign in to comment.