[Github] Use hashed dependencies in docs job #120319
Merged
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch forces the docs test build job to use the hashed dpendencies file rather than the normal requirements.txt. This ensures that we get the exact transitive closure specified rather than whatever the dependency solver feels like it should use in the CI job.
|
@llvm/pr-subscribers-github-workflow Author: Aiden Grossman (boomanaiden154) ChangesThis patch forces the docs test build job to use the hashed dpendencies file rather than the normal requirements.txt. This ensures that we get the exact transitive closure specified rather than whatever the dependency solver feels like it should use in the CI job. Full diff: https://github.com/llvm/llvm-project/pull/120319.diff 1 Files Affected:
diff --git a/.github/workflows/docs.yml b/.github/workflows/docs.yml
index 8441589bb716e0..b4fa27203236a0 100644
--- a/.github/workflows/docs.yml
+++ b/.github/workflows/docs.yml
@@ -106,9 +106,9 @@ jobs:
with:
python-version: '3.11'
cache: 'pip'
- cache-dependency-path: 'llvm/docs/requirements.txt'
+ cache-dependency-path: 'llvm/docs/requirements-hashed.txt'
- name: Install python dependencies
- run: pip install -r llvm/docs/requirements.txt
+ run: pip install -r llvm/docs/requirements-hashed.txt
- name: Install system dependencies
run: |
sudo apt-get update
|
|
Seems ok to me, but should I change llvm/llvm-zorg#345 to also use the hashed file? If anything, I'd defer to @marcauberer for the review of this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch forces the docs test build job to use the hashed dpendencies file rather than the normal requirements.txt. This ensures that we get the exact transitive closure specified rather than whatever the dependency solver feels like it should use in the CI job.