Skip to content

Commit

Permalink
[libc++] Re-enable Clang-tidy checks in the CI (#110026)
Browse files Browse the repository at this point in the history
Now that we've gained control of our CI docker image again,
we can re-enable the clang-tidy tests.
  • Loading branch information
ldionne authored Dec 2, 2024
1 parent 94316dd commit 3d43789
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 5 deletions.
1 change: 0 additions & 1 deletion libcxx/include/chrono
Original file line number Diff line number Diff line change
Expand Up @@ -998,7 +998,6 @@ constexpr chrono::year operator ""y(unsigned lo
# include <cstdint>
# include <stdexcept>
# include <string_view>
# include <vector>
#endif

#if !defined(_LIBCPP_REMOVE_TRANSITIVE_INCLUDES) && _LIBCPP_STD_VER <= 20
Expand Down
3 changes: 2 additions & 1 deletion libcxx/test/libcxx/clang_tidy.gen.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@

import sys
sys.path.append(sys.argv[1])
from libcxx.header_information import lit_header_restrictions, public_headers
from libcxx.header_information import lit_header_restrictions, lit_header_undeprecations, public_headers

for header in public_headers:
print(f"""\
Expand All @@ -30,6 +30,7 @@
// UNSUPPORTED: clang-17
{lit_header_restrictions.get(header, '')}
{lit_header_undeprecations.get(header, '')}
// TODO: run clang-tidy with modules enabled once they are supported
// RUN: %{{clang-tidy}} %s --warnings-as-errors=* -header-filter=.* --checks='-*,libcpp-*' --load=%{{test-tools-dir}}/clang_tidy_checks/libcxx-tidy.plugin -- %{{compile_flags}} -fno-modules
Expand Down
3 changes: 0 additions & 3 deletions libcxx/test/tools/clang_tidy_checks/CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
# TODO: Re-enable the tests once the CI is back under control
return()

# The find_package changes these variables. This leaves the build in an odd
# state. Calling cmake a second time tries to write site config information in
# the system's libc++. Restoring these setting after testing fixes this issue.
Expand Down

0 comments on commit 3d43789

Please sign in to comment.