fix(format): correct duplicated statistics names (apache#1736)

Fixes apache#1688.
llama90 · Apr 22, 2024 · 75a4b64 · 75a4b64
1 parent 922e69b
commit 75a4b64
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 12 deletions.
diff --git a/adbc.h b/adbc.h
@@ -546,15 +546,15 @@ const struct AdbcError* AdbcErrorFromArrayStream(struct ArrowArrayStream* stream
 ///   (when approximate).
 ///
 /// For example, this is the maximum length of a string for a string column.
-#define ADBC_STATISTIC_MAX_BYTE_WIDTH_NAME "adbc.statistic.byte_width"
+#define ADBC_STATISTIC_MAX_BYTE_WIDTH_NAME "adbc.statistic.max_byte_width"
 /// \brief The dictionary-encoded name of the max value statistic.
 #define ADBC_STATISTIC_MAX_VALUE_KEY 3
 /// \brief The max value statistic.  Value type is column-dependent.
-#define ADBC_STATISTIC_MAX_VALUE_NAME "adbc.statistic.byte_width"
+#define ADBC_STATISTIC_MAX_VALUE_NAME "adbc.statistic.max_value"
 /// \brief The dictionary-encoded name of the min value statistic.
 #define ADBC_STATISTIC_MIN_VALUE_KEY 4
 /// \brief The min value statistic.  Value type is column-dependent.
-#define ADBC_STATISTIC_MIN_VALUE_NAME "adbc.statistic.byte_width"
+#define ADBC_STATISTIC_MIN_VALUE_NAME "adbc.statistic.min_value"
 /// \brief The dictionary-encoded name of the null count statistic.
 #define ADBC_STATISTIC_NULL_COUNT_KEY 5
 /// \brief The null count statistic.  The number of values that are null in

diff --git a/go/adbc/adbc.go b/go/adbc/adbc.go
@@ -287,15 +287,15 @@ const (
 	// approximate).
 	//
 	// For example, this is the maximum length of a string for a string column.
-	StatisticMaxByteWidthName = "adbc.statistic.byte_width"
+	StatisticMaxByteWidthName = "adbc.statistic.max_byte_width"
 	// The dictionary-encoded name of the max value statistic.
 	StatisticMaxValueKey = 3
 	// The max value statistic.  Value type is column-dependent.
-	StatisticMaxValueName = "adbc.statistic.byte_width"
+	StatisticMaxValueName = "adbc.statistic.max_value"
 	// The dictionary-encoded name of the min value statistic.
 	StatisticMinValueKey = 4
 	// The min value statistic.  Value type is column-dependent.
-	StatisticMinValueName = "adbc.statistic.byte_width"
+	StatisticMinValueName = "adbc.statistic.min_value"
 	// The dictionary-encoded name of the null count statistic.
 	StatisticNullCountKey = 5
 	// The null count statistic.  The number of values that are null in the

diff --git a/go/adbc/drivermgr/adbc.h b/go/adbc/drivermgr/adbc.h
diff --git a/java/core/src/main/java/org/apache/arrow/adbc/core/StandardStatistics.java b/java/core/src/main/java/org/apache/arrow/adbc/core/StandardStatistics.java
@@ -44,11 +44,11 @@ public enum StandardStatistics {
    *
    * <p>For example, this is the maximum length of a string for a string column.
    */
-  MAX_BYTE_WIDTH("adbc.statistic.byte_width", (short) 2),
+  MAX_BYTE_WIDTH("adbc.statistic.max_byte_width", (short) 2),
   /** The max value statistic. Value type is column-dependent. */
-  MAX_VALUE("adbc.statistic.byte_width", (short) 3),
+  MAX_VALUE("adbc.statistic.max_value", (short) 3),
   /** The min value statistic. Value type is column-dependent. */
-  MIN_VALUE("adbc.statistic.byte_width", (short) 4),
+  MIN_VALUE("adbc.statistic.min_value", (short) 4),
   /**
    * The null count statistic. The number of values that are null in the column. Value type is int64
    * (when not approximate) or float64 (when approximate).