Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

urls: wait for all expected services #479

Closed
wants to merge 2 commits into from
Closed

urls: wait for all expected services #479

wants to merge 2 commits into from

Conversation

royra
Copy link
Collaborator

@royra royra commented Apr 21, 2024

wait for all expected services to be returned from the CTA query

@royra royra requested a review from Yshayy April 21, 2024 10:24
@royra royra force-pushed the urls-wait-for-all-services branch from 8b41cce to 0f0b13a Compare April 21, 2024 10:25
Yshayy
Yshayy reviewed May 9, 2024
View reviewed changes
Copy link
Contributor

@Yshayy Yshayy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will it work correctly for compose services that are ran to completion and not live (like init, data seeding, etc...)

urls: wait for all expected services
869a403 
wait for all expected services to be returned from the CTA query
@royra royra force-pushed the urls-wait-for-all-services branch from 0f0b13a to 869a403 Compare May 9, 2024 10:50
@royra royra mentioned this pull request May 11, 2024
Merged
@royra
Copy link
Collaborator Author

royra commented May 11, 2024

Superseded by #488

@royra royra closed this May 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yshayy Yshayy Yshayy left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@royra @Yshayy