-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved grammar and fixed spelling and punctuation in the documentation. #374
Changes from 7 commits
30b6465
e95cd86
6ec2fb1
b27f382
5ce1bfa
14367e7
12513f3
5be1176
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -35,7 +35,7 @@ There are 2 options to develop preevy locally: | |
## Option 1 - Using the public livecycle.run Tunnel Server | ||
|
||
|
||
This option is simpler and using the the deployed Tunnel Server under livecycle.run. Use this if you're only interested in testing and developing the CLI or the Compose Tunnel Agent | ||
This option is simpler and uses the deployed Tunnel Server under livecycle.run. Use this if you're only interested in testing and developing the CLI or the Compose Tunnel Agent | ||
|
||
Wherever you would normally run the `preevy` command, simply replace it with: | ||
|
||
|
@@ -75,7 +75,7 @@ BASE_URL=http://localhost:8030 docker compose -f docker-compose.yml -f docker-co | |
|
||
### 3. Expose the service's SSH endpoint | ||
|
||
Now we want to expose the tunnel service to the internet, so the machines running in the cloud could access it. In this example we'll be using [ngrok](https://ngrok.com/) to achieve that: | ||
Now we want to expose the tunnel service to the internet, so the machines running in the cloud can access it. In this example, we'll be using [ngrok](https://ngrok.com/) to achieve that: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. not sure removing the comma makes a better or more correct sentence There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No comma is removed; instead, one is added. |
||
|
||
```bash | ||
ngrok tcp 2223 | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,6 +5,6 @@ parent: /dashboard | |
|
||
## **Share code changes. Collect feedback.** | ||
|
||
Livecycle makes it easy to not only create previews of your latest changes, but also to share them and collect feedback in context. | ||
Livecycle makes it easy to not only create previews of your latest changes but also to share them and collect feedback in context. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. not sure removing the comma makes a better or more correct sentence There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is correct according to Grammarly. |
||
|
||
Using the Dashboard, you can invite teammates to ephemeral environments to review and provide feedback. Each team member can see the open projects assigned to them and review changes in their browser. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CLI reference is auto-generated from the code - any changes will be reverted. You can make the change at the appropriate file in the
commands
dirThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have now made the change in the appropriate file. I am leaving this here so that these docs remain updated.