docs: Add docs for Livecycle Docker extension #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
royra
reviewed
Oct 19, 2023
There was a problem hiding this comment.
Lots of nit comments, but the thing that really needs to be worked out is explaining the voyage from trying out the extension, to trying the preevy CLI, to integrating it in the CLI. I think this deserves a section on its own (@Yshayy I suggest you phrase the initial version).
| <summary>What makes Livecycle Docker Extension different from other tools?</summary> | ||
| <p> | ||
| Support provisioning to your cloud provider or k8s cluster -> In that context we are not bound to abilities like tunnel or ngrok as we allow the environment to be available and accessible regardless of your local setup. We also support your CI pipeline- showing that it can be added to your GH actions for example while also add comments to your GH. |
There was a problem hiding this comment.
This explanation needs some clarification - you can't really do those things with just the extension.
Suggested change
| Support provisioning to your cloud provider or k8s cluster -> In that context we are not bound to abilities like tunnel or ngrok as we allow the environment to be available and accessible regardless of your local setup. We also support your CI pipeline- showing that it can be added to your GH actions for example while also add comments to your GH. | |
| Support provisioning to your cloud provider or k8s cluster -> In that context we are not bound to abilities like tunnel or ngrok as we allow the environment to be available and accessible regardless of your local setup. We also support your CI pipeline- showing that it can be added to your GH actions for example while also add comments to your GH. |
There was a problem hiding this comment.
Hey, thanks
Can you tell me what should I write instead of that?
Co-authored-by: Roy Razon <[email protected]>
Co-authored-by: Roy Razon <[email protected]>
Co-authored-by: Roy Razon <[email protected]>
Co-authored-by: Roy Razon <[email protected]>
Co-authored-by: Roy Razon <[email protected]>
Co-authored-by: Roy Razon <[email protected]>
Co-authored-by: Roy Razon <[email protected]>
Co-authored-by: Roy Razon <[email protected]>
Co-authored-by: Roy Razon <[email protected]>
Co-authored-by: Roy Razon <[email protected]>
Co-authored-by: Roy Razon <[email protected]>
Co-authored-by: Roy Razon <[email protected]>
Pradumnasaraf
commented
Oct 19, 2023
Yshayy
reviewed
Oct 23, 2023
royra
reviewed
Oct 23, 2023
| Consistent URLs, private environments, organizations and Google/Github authentication are supported out of the box. | ||
| Livecycle dashboard provides debugging capabilites that includes log inspection, shell access, and container inspection. | ||
| Lastly, the integration with Preevy allow you to create remote ephemeral environments that can be used when your workstation is offline or futher in your SDLC (preview environments for Pull Requests). |
There was a problem hiding this comment.
IMO further in your SDLC is too jargon
There was a problem hiding this comment.
I don't like it that much, as well, but it's the best I could come up with to indicate it can be used further in the development process.
Yshayy
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add docs for Livecycle Docker Extension
This is a
Preview
Screen.Recording.2023-10-19.at.12.16.16.PM.mov
Note:
Later we can add how it's connected to Preevy and Livecycle Saas