Feature/azure blob storage for profile store #156
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hassansuhaib
force-pushed
the
feature/azure_blob_storage_for_profile_store
branch
2 times, most recently
from
e5ff378 to
d08f842
Compare
hassansuhaib
force-pushed
the
feature/azure_blob_storage_for_profile_store
branch
from
d08f842 to
649874e
Compare
hassansuhaib
force-pushed
the
feature/azure_blob_storage_for_profile_store
branch
from
48548e1 to
701f41c
Compare
Yshayy
reviewed
Sep 18, 2023
hassansuhaib
force-pushed
the
feature/azure_blob_storage_for_profile_store
branch
from
81c0900 to
b1af71c
Compare
Boilerplate for Azure FS
Registered azure fs driver Exported azure fs package
Changed method for getting blob service client
hassansuhaib
force-pushed
the
feature/azure_blob_storage_for_profile_store
branch
from
b1af71c to
426c37c
Compare
Removed unwanted return statement Changed https to az Improved function name to alight with Azure terminology
|
fixed by #423 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #102
Implemented Azure Blob storage for Profile Store
This approach requires these environment variables to be set by the user:
AZURE_TENANT_ID,AZURE_CLIENT_ID,AZURE_CLIENT_SECRETbecause we can't use other methods for creating a blob service account as they require different keys and we only get URL as a param.