Skip to content

Commit

Permalink
fix: command id parsing bug in oclif
Browse files Browse the repository at this point in the history
patch for PR oclif/core#886
  • Loading branch information
Roy Razon committed Nov 27, 2023
1 parent e4ed7c3 commit f6dd2f9
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 1 deletion.
3 changes: 2 additions & 1 deletion packages/cli/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@
"inquirer-autocomplete-prompt": "^2.0.0",
"iter-tools-es": "^7.5.3",
"lodash": "^4.17.21",
"patch-package": "^8.0.0",
"shell-escape": "^0.2.0",
"yaml": "^2.3.2"
},
Expand Down Expand Up @@ -104,7 +105,7 @@
"prepack": "yarn build && oclif manifest && oclif readme --dir docs --multi && ./scripts/prepare_and_copy_docs.sh",
"cli": "./bin/dev",
"version": "oclif readme && git add README.md",
"bump-to": "yarn version --no-commit-hooks --no-git-tag-version --new-version"
"postinstall": "$(npm bin)/patch-package"
},
"engines": {
"node": ">=18.0.0"
Expand Down
13 changes: 13 additions & 0 deletions patches/@oclif+core+3.12.0.patch
Original file line number Diff line number Diff line change
@@ -1,3 +1,16 @@
diff --git a/node_modules/@oclif/core/lib/help/util.js b/node_modules/@oclif/core/lib/help/util.js
index 6c97a31..3a7ace6 100644
--- a/node_modules/@oclif/core/lib/help/util.js
+++ b/node_modules/@oclif/core/lib/help/util.js
@@ -43,7 +43,7 @@ function collateSpacedCmdIDFromArgs(argv, config) {
const ids = (0, util_1.collectUsableIds)(config.commandIDs);
const final = [];
const idPresent = (id) => ids.has(id);
- const finalizeId = (s) => (s ? [...final, s].join(':') : final.join(':'));
+ const finalizeId = (s) => (s ? [...final, s] : final).filter(Boolean).join(':');
const hasArgs = () => {
const id = finalizeId();
if (!id)
diff --git a/node_modules/@oclif/core/lib/interfaces/parser.d.ts b/node_modules/@oclif/core/lib/interfaces/parser.d.ts
index acb8583..2d53745 100644
--- a/node_modules/@oclif/core/lib/interfaces/parser.d.ts
Expand Down

0 comments on commit f6dd2f9

Please sign in to comment.