ssh connection metrics should be aggregated by clientId (#394)

livecycle · Jan 30, 2024 · 5cd3e97 · 5cd3e97
1 parent 50deaa8
commit 5cd3e97
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/tunnel-server/src/metrics.ts b/tunnel-server/src/metrics.ts
@@ -4,7 +4,7 @@ import { Gauge, Counter, register } from 'prom-client'
 export const sshConnectionsGauge = new Gauge({
   name: 'sshConnections',
   help: 'Current number of open SSH connections',
-  labelNames: ['envId'],
+  labelNames: ['clientId'],
 })
 
 export const tunnelsGauge = new Gauge({

diff --git a/tunnel-server/src/ssh/index.ts b/tunnel-server/src/ssh/index.ts
@@ -28,8 +28,8 @@ export const createSshServer = ({
 }) => {
   const onClient = (client: BaseSshClient) => {
     const { clientId, publicKey, envId, connectionId, publicKeyThumbprint, log } = client
-    sshConnectionsGauge.inc({ envId })
-    const cleanupClient = once(() => { sshConnectionsGauge.dec({ envId }) })
+    sshConnectionsGauge.inc({ clientId })
+    const cleanupClient = once(() => { sshConnectionsGauge.dec({ clientId }) })
     const tunnels = new Map<string, string>()
     client
       .on('forward', async (requestId, { path: tunnelPath, access, meta, inject }, localSocketPath, accept, reject) => {