Send parentchain extrinsics as mortal #3205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Try to mitigate the invalid tx situation by specifying them as mortal - the mortality at least gives the tx pool a chance to consider a tx as invalid once expired (and thus prune it from tx pool).
We should rarely need immortal extrinsic - so the current impl is definitely flawed.
In my local tests, it looks better - I don't see missing
ParentchainBlockProcessedevents anymore.It doesn't solve all the problems tho, some tx will still be marked as invalid in the first submission with no reason being specified.
Ideally the
validator_accessorandextrinsic_factorycould be merged (as creating parentchain extrinsic requires parentchain state), but for now no big change is made until we rewrite it.