Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to polkadot-sdk v1.11.0 #3190

Merged

Conversation

Kailai-Wang
Copy link
Collaborator

@Kailai-Wang Kailai-Wang commented Dec 4, 2024

Context

As topic.

Some notes:

  • xcm needs an overhaul, we are way behind (it's v4 now), plus we don't use it actively, so I turn most of the settings "off", as well as integration tests - @wangminqi please double-check the config to make sure there's no token transfer via XCM possible
  • rococo runtime is removed
  • orml is dismissed, it seems the forked branch would still introduce compile errors. The original orml uses crates.io based deps. The OrderedSet is copied over manually @wangminqi
  • sp_core_hashing introduces std feature unintentionally, thus superseded by sp_core::hashing
  • the node code is based on cumulus template code, some more RPC methods are introduced
  • rust toolchain is upgraded to 1.81
  • the finalisation delay is fixed
  • feature propagation is fixed using zepter

Due to re-org, sometimes (especially in the dev) you can see tx status Retracted, but eventually it will be finalised. To deal with that in the enclave registration, I've forked https://github.com/Kailai-Wang/substrate-api-client/tree/polkadot-v0.9.42-litentry to allow Retracted status - base repo has something similar too: scs/substrate-api-client#807

As a (partial) consequence, I need to wait for Finalized status (instead of InBlock) in the account funding in the worker initialisation.

See also: https://substrate.stackexchange.com/questions/8872/when-is-a-transaction-retracted/8873#8873

Main files to review:

  • files under parachain/node/
  • litentry/paseo runtime configurations
  • worker changes

@Kailai-Wang Kailai-Wang self-assigned this Dec 4, 2024
Copy link

linear bot commented Dec 4, 2024

@Kailai-Wang Kailai-Wang requested review from wangminqi, silva-fj, kziemianek and a team December 4, 2024 15:46
@wangminqi
Copy link
Member

wangminqi commented Dec 6, 2024

XCM part LGTM

Copy link
Collaborator

@BillyWooo BillyWooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@Kailai-Wang
Copy link
Collaborator Author

There seems to be some race conditions regarding parachain ext submission - it can be related to the missing parachain events that we found earlier.

I'm trying to add more logs to debug it, so don't merge it now

@Kailai-Wang Kailai-Wang merged commit b62c3e2 into dev Dec 9, 2024
24 checks passed
@Kailai-Wang Kailai-Wang deleted the p-1165-one-extra-block-delay-in-finalising-parachain-tx branch December 9, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants