-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to polkadot-sdk v1.11.0 #3190
Merged
Kailai-Wang
merged 25 commits into
dev
from
p-1165-one-extra-block-delay-in-finalising-parachain-tx
Dec 9, 2024
Merged
Upgrade to polkadot-sdk v1.11.0 #3190
Kailai-Wang
merged 25 commits into
dev
from
p-1165-one-extra-block-delay-in-finalising-parachain-tx
Dec 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* upgrade @polkadot/* deps * update lock yaml * revert deps version
wangminqi
reviewed
Dec 5, 2024
BillyWooo
reviewed
Dec 5, 2024
XCM part LGTM |
BillyWooo
approved these changes
Dec 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks.
There seems to be some race conditions regarding parachain ext submission - it can be related to the missing parachain events that we found earlier. I'm trying to add more logs to debug it, so don't merge it now |
kziemianek
approved these changes
Dec 6, 2024
silva-fj
approved these changes
Dec 9, 2024
Kailai-Wang
deleted the
p-1165-one-extra-block-delay-in-finalising-parachain-tx
branch
December 9, 2024 09:03
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
As topic.
Some notes:
OrderedSet
is copied over manually @wangminqisp_core_hashing
introduces std feature unintentionally, thus superseded bysp_core::hashing
Due to re-org, sometimes (especially in the dev) you can see tx status
Retracted
, but eventually it will be finalised. To deal with that in the enclave registration, I've forked https://github.com/Kailai-Wang/substrate-api-client/tree/polkadot-v0.9.42-litentry to allowRetracted
status - base repo has something similar too: scs/substrate-api-client#807As a (partial) consequence, I need to wait for
Finalized
status (instead ofInBlock
) in the account funding in the worker initialisation.See also: https://substrate.stackexchange.com/questions/8872/when-is-a-transaction-retracted/8873#8873
Main files to review:
parachain/node/