Optimize parachain events handling #3216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kailai-Wang
approved these changes
Dec 22, 2024
There was a problem hiding this comment.
Good catch, thanks!
Some small improvements that we could make:
- we could define a collection of
impl StaticEvent(to simplify the code) and matchanyof them in `FilterableEvents::new() - it should have better readability and maintainability - we could clean-up the interested events a bit - e.g. we don't actually care about
ParentchainBlockProcessedevents - but including them in the interested events would actually push them into the post-processing including merkle root calculation
Kailai-Wang
deleted the
p-1248-sidechain-block-production-takes-to-long
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Iterate parachain's events only once and keep only events worker is interested in.
This should reduce time spent by event handler during parachain's event processing. It doesn't guarantee that sidechain block events will come out every 6 s.