-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: P-1203 unified npm package version #3195
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
higherordertech
force-pushed
the
P-1203-resolve-conflicting-packages-in-ts-tests
branch
from
December 10, 2024 03:26
4b4b061
to
1af755f
Compare
higherordertech
force-pushed
the
P-1203-resolve-conflicting-packages-in-ts-tests
branch
from
December 10, 2024 19:47
1af755f
to
01367a8
Compare
@0xverin please review it : ) |
0xverin
reviewed
Dec 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- After deleting
pnpm-lock.yaml
andnode_modules
, there are still many unmet peers when running pnpm install. I think the lock file should be deleted(at least at this update) and then update the package for testing, otherwise, it's impossible to know the correct version range of the package, as the locked version is used during pnpm install.
- ts-tests still have unmet peers (tested without deleting pnpm-lock.yaml).
- Can you find a way to run all the tests in CI (like adding a console.log in tests to triggle ci or something), the CI passed, but actually none of the tests were run?I am worried that with version modifications, some methods may become ineffective. thank you.
higherordertech
force-pushed
the
P-1203-resolve-conflicting-packages-in-ts-tests
branch
from
December 18, 2024 02:02
01367a8
to
fb3b933
Compare
0xverin
force-pushed
the
P-1203-resolve-conflicting-packages-in-ts-tests
branch
from
December 19, 2024 07:44
6519ad9
to
da10647
Compare
0xverin
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Fixing conflicting npm package.
Labels
Please apply following PR-related labels when appropriate:
C0-breaking
: if your change could break the existing client, e.g. API change, critical logic changeC1-noteworthy
: if your change is non-breaking, but is still worth noticing for the client, e.g. reference code improvementHow (Optional)
Testing Evidences
Please attach any relevant evidences if applicable