Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: P-1203 unified npm package version #3195

Merged
merged 8 commits into from
Dec 19, 2024

Conversation

higherordertech
Copy link
Contributor

Context

Fixing conflicting npm package.

Labels

Please apply following PR-related labels when appropriate:

  • C0-breaking: if your change could break the existing client, e.g. API change, critical logic change
  • C1-noteworthy: if your change is non-breaking, but is still worth noticing for the client, e.g. reference code improvement

How (Optional)

Testing Evidences

Please attach any relevant evidences if applicable

Copy link

linear bot commented Dec 10, 2024

@higherordertech higherordertech force-pushed the P-1203-resolve-conflicting-packages-in-ts-tests branch from 4b4b061 to 1af755f Compare December 10, 2024 03:26
@higherordertech higherordertech marked this pull request as ready for review December 10, 2024 03:41
@Kailai-Wang Kailai-Wang requested review from 0xverin and a team December 10, 2024 16:08
@higherordertech higherordertech force-pushed the P-1203-resolve-conflicting-packages-in-ts-tests branch from 1af755f to 01367a8 Compare December 10, 2024 19:47
@Kailai-Wang
Copy link
Collaborator

@0xverin please review it : )

Copy link
Contributor

@0xverin 0xverin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. After deleting pnpm-lock.yaml and node_modules, there are still many unmet peers when running pnpm install. I think the lock file should be deleted(at least at this update) and then update the package for testing, otherwise, it's impossible to know the correct version range of the package, as the locked version is used during pnpm install.
image
  1. ts-tests still have unmet peers (tested without deleting pnpm-lock.yaml).
image
  1. Can you find a way to run all the tests in CI (like adding a console.log in tests to triggle ci or something), the CI passed, but actually none of the tests were run?I am worried that with version modifications, some methods may become ineffective. thank you.

@higherordertech higherordertech force-pushed the P-1203-resolve-conflicting-packages-in-ts-tests branch from 01367a8 to fb3b933 Compare December 18, 2024 02:02
@higherordertech
Copy link
Contributor Author

  1. After deleting pnpm-lock.yaml and node_modules, there are still many unmet peers when running pnpm install. I think the lock file should be deleted(at least at this update) and then update the package for testing, otherwise, it's impossible to know the correct version range of the package, as the locked version is used during pnpm install.
image 2. ts-tests still have unmet peers (tested without deleting pnpm-lock.yaml). image 3. Can you find a way to run all the tests in CI (like adding a console.log in tests to triggle ci or something), the CI passed, but actually none of the tests were run?I am worried that with version modifications, some methods may become ineffective. thank you.

fixed now.

@0xverin 0xverin force-pushed the P-1203-resolve-conflicting-packages-in-ts-tests branch from 6519ad9 to da10647 Compare December 19, 2024 07:44
@0xverin
Copy link
Contributor

0xverin commented Dec 19, 2024

  1. After deleting pnpm-lock.yaml and node_modules, there are still many unmet peers when running pnpm install. I think the lock file should be deleted(at least at this update) and then update the package for testing, otherwise, it's impossible to know the correct version range of the package, as the locked version is used during pnpm install.
image 2. ts-tests still have unmet peers (tested without deleting pnpm-lock.yaml). image 3. Can you find a way to run all the tests in CI (like adding a console.log in tests to triggle ci or something), the CI passed, but actually none of the tests were run?I am worried that with version modifications, some methods may become ineffective. thank you.

fixed now.

I also fixed the issues after the solc upgrade In parachain ts-tests.

@0xverin 0xverin merged commit 55624db into dev Dec 19, 2024
22 checks passed
@0xverin 0xverin deleted the P-1203-resolve-conflicting-packages-in-ts-tests branch December 19, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants