fix saml login errors after rebase on a+ #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goapunk
commented
Oct 21, 2024
| @@ -15,21 +13,19 @@ def apply_custom_overwrites(): | |||
|
|
|||
|
|
|||
| def customize_session(self, user, session_info): | |||
| user_obj = User.objects.get(email=user) | |||
| if not EmailAddress.objects.filter(user=user_obj, email=user).exists(): | |||
There was a problem hiding this comment.
passing email=user doesn't work anymore, I'm not entirely sure why
There was a problem hiding this comment.
because of the latest allauth, we changed I think the mandatory fields. did you try email=user.email?
There was a problem hiding this comment.
yes, this is what I did in this PR
goapunk
force-pushed
the
jd-2024-10-fix-saml-sign-in
branch
from
7dac925 to
70bf03e
Compare
goapunk
commented
Oct 22, 2024
| ], | ||
| }, | ||
| "required_attributes": ["mail"], | ||
| "allow_unsolicited": False, |
There was a problem hiding this comment.
the only thing which changed here is adding this line, the rest was auto-formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tasks