Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7931] templates/home_page: add anchor links for blocks according to WCAG ta… #949

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

philli-m
Copy link
Contributor

@philli-m philli-m commented Dec 13, 2023

…ble of contents

Used @goapunk streamfield id solution and used Mozilla example, as not all the blocks have a header it make sense to add the id to the section/article element
NOTE: This should be added to other pages, only testable on home page and direct subpages currently.

I think we also need to add help text for editors to identify the block id's in the dashbaord, made sample text but it's a bit long?!

When you want to add an anchor tag to a section, follow these steps:
Navigate to the block in the editing interface.
Click the chain link icon next to the block.
In the page URL bar, you will see a collection of numbers and letters after the '#' symbol. Copy everything after '#'; this is your anchor link for that section.
Use this copied value as the anchor link when needed.

@philli-m philli-m requested review from goapunk and hom3mad3 December 13, 2023 12:50
@philli-m philli-m force-pushed the pm-2023-12-anchor-links branch 2 times, most recently from 5314d83 to 057c2ee Compare December 13, 2023 14:36
Copy link
Contributor

@goapunk goapunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just the removal of the unused template tag

apps/home/templates/apps_home/home_page.html Outdated Show resolved Hide resolved
@goapunk
Copy link
Contributor

goapunk commented Dec 13, 2023

Maybe a short helptext:

To get the anchor tag for this block: click the chain link symbol at the top left of the block and copy the id from the url (example: block-1e495692-5fad-4133-86c5-0c42e19b4ad2-section)

?

@philli-m philli-m force-pushed the pm-2023-12-anchor-links branch from 057c2ee to 23208c1 Compare December 14, 2023 12:59
@philli-m philli-m changed the title templates/home_page: add anchor links for blocks according to WCAG ta… [7931] templates/home_page: add anchor links for blocks according to WCAG ta… Dec 14, 2023
@philli-m philli-m requested review from goapunk and m4ra December 14, 2023 13:01
Copy link
Contributor

@goapunk goapunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@philli-m philli-m force-pushed the pm-2023-12-anchor-links branch from 23208c1 to 5b4b47e Compare December 14, 2023 15:42
Copy link
Contributor

@hom3mad3 hom3mad3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hom3mad3 hom3mad3 merged commit e7afb9a into main Dec 14, 2023
3 checks passed
@hom3mad3 hom3mad3 deleted the pm-2023-12-anchor-links branch December 14, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants