Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

makefile: add media folder on make install to ensure app can find foo… #872

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

philli-m
Copy link
Contributor

@philli-m philli-m commented Oct 4, 2023

…ter on first make watch

@philli-m philli-m requested a review from goapunk October 4, 2023 07:28
Copy link
Contributor

@goapunk goapunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs update to be same as in mb now

@philli-m
Copy link
Contributor Author

philli-m commented Oct 25, 2023

@goapunk a little more context?

have made it like this? https://github.com/liqd/a4-meinberlin/pull/5252/files

@philli-m philli-m closed this Oct 25, 2023
@philli-m philli-m reopened this Oct 25, 2023
@philli-m philli-m force-pushed the pm-2023-10-media-folder branch from 3639a34 to 7666364 Compare October 25, 2023 15:10
@philli-m philli-m requested review from goapunk, m4ra and hom3mad3 October 25, 2023 15:10
Copy link
Contributor

@goapunk goapunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goapunk goapunk merged commit 8b56b9f into main Oct 26, 2023
2 checks passed
@goapunk goapunk deleted the pm-2023-10-media-folder branch October 26, 2023 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants