poll: hide back to poll button for unregistered users #1691
Conversation
goapunk
force-pushed
the
jd-2024-11-fix-blocked-polls
branch
from
a06d01e to
a24a668
Compare
| <div className="poll"> | ||
| {this.state.hasUserVote ? this.linkChangeVote : this.linkToPoll} | ||
| </div> | ||
| {this.state.questions.length > 0 && this.state.questions[0].authenticate && |
There was a problem hiding this comment.
we could put this.state.questions[0].authenticate into a variable with a meaningful name (i.e. registeredUser, logged in etc)?
also a note for eventual refactoring: {this.state.hasUserVote ? this.linkChangeVote : this.linkToPoll} doesn't immediate show what type of element we are rendering, we should probably have the <button> receive an onclick event which handles things for us.
There was a problem hiding this comment.
yeah all the conditions in here could need a refactor, the chains are terribly long and hard to read. (Some of them could ideally be already done in the backend as well I think), I just made it work with minimal effort for now
There was a problem hiding this comment.
I will merge this now, refactoring will happen when PM will budget resources for that.
Tasks