-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed datepicker for flatpicker #2790
Conversation
@rjlanari you are right! I didn't rebuild the npm. Works as expected now, I will go ahead and merge. Thank you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
@rjlanari can you run a rebase with main from your branch?
if any conflicts that you cannot resolve, let me know in mattermorst. |
453833f
to
218c616
Compare
$inputs.addClass('form-control') | ||
function initDatePicker () { | ||
const datepickers = document.querySelectorAll('.datepicker') | ||
const format = django.get_format('DATE_INPUT_FORMATS')[0].replaceAll('%', '') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we could add a fallback date format here const format = django.get_format ? django.get_format('DATE_INPUT_FORMATS')[0].replaceAll('%', '') : 'Y-m-d';
|
||
$inputs.addClass('form-control') | ||
function initDatePicker () { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest splitting into smaller, well-named chunks and then call them inside the function. It will make the code easier to read and maintain and we can keep the main initializer nice and clean.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure if that's something @rjlanari wants to take over as the focus was more on django, what do you think @rjlanari ? Otherwise maybe you can work on that @hom3mad3 if you have an idea in mind? If we change it we should port it over to mb (or if both files are identical we could even consider moving it into a4)
218c616
to
1fcc0e0
Compare
*Replace the old datepicker with flatpickr and connect the flatpickr instances (if there are multiple ones, e.g. for module phases).