Skip to content

Commit

Permalink
react/ratings: move icon overwrite out and into a4, change hover style
Browse files Browse the repository at this point in the history
  • Loading branch information
vellip committed Nov 28, 2024
1 parent b71f9e6 commit 436f6f7
Show file tree
Hide file tree
Showing 4 changed files with 13 additions and 14 deletions.
6 changes: 6 additions & 0 deletions changelog/8529.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
### Removed
- thumbs up/down icons in ratings because they are now in a4

### Added
- hover style for rating buttons
- active style for rating buttons
17 changes: 5 additions & 12 deletions meinberlin/assets/scss/components_user_facing/_rating.scss
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@

.rating__label {
word-break: normal;
margin-left: 0.4em;
}

.rating-button {
Expand All @@ -18,22 +17,16 @@
padding: 0;

i {
margin-right: 0.4em;
margin-bottom: 0.4em;
display: inline;
font-weight: normal;
}

&--active {
&--active,
&.is-selected {
font-weight: bold;
}

.fa-chevron-up:before {
content:"\f164"!important; // thumbs-up icon
font-weight: 400;
}

.fa-chevron-down:before {
content:"\f165"!important; // thumbs-down icon
font-weight: 400;
&:hover {
text-decoration: underline;
}
}
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"@react-leaflet/core": "^2.1.0",
"@turf/turf": "^6.5.0",
"acorn": "8.12.0",
"adhocracy4": "liqd/adhocracy4#e10457d42e72d39d305c2579c5de5ce98f65be9c",
"adhocracy4": "liqd/adhocracy4#91852f59c54ac8ad5ee9cebeb66fa975c66f54d1",
"autoprefixer": "10.4.19",
"bootstrap": "5.2.3",
"copy-webpack-plugin": "12.0.2",
Expand Down
2 changes: 1 addition & 1 deletion requirements/base.txt
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# A4
git+https://github.com/liqd/adhocracy4.git@e10457d42e72d39d305c2579c5de5ce98f65be9c#egg=adhocracy4
git+https://github.com/liqd/adhocracy4.git@91852f59c54ac8ad5ee9cebeb66fa975c66f54d1#egg=adhocracy4

# Additional requirements
beautifulsoup4==4.11.2
Expand Down

0 comments on commit 436f6f7

Please sign in to comment.