Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8022] change platform styling #2

Merged
merged 3 commits into from
Feb 19, 2024
Merged

[8022] change platform styling #2

merged 3 commits into from
Feb 19, 2024

Conversation

goapunk
Copy link
Contributor

@goapunk goapunk commented Feb 19, 2024 •
edited
Loading

Tasks

  • PR name contains story or task reference
  • Documentation (docs and inline)
  • Tests (including n+1 and django_assert_num_queries where applicable)
  • Changelog

@goapunk goapunk changed the title Jd 2024 02 change styling [8022] change platform styling Feb 19, 2024
@goapunk goapunk force-pushed the jd-2024-02-change-styling branch 2 times, most recently from 1c7602b to 3a43499 Compare February 19, 2024 10:43
@goapunk goapunk requested a review from hom3mad3 February 19, 2024 10:50
@goapunk goapunk force-pushed the jd-2024-02-change-styling branch from 3a43499 to feb6f32 Compare February 19, 2024 10:53
@goapunk goapunk requested a review from hom3mad3 February 19, 2024 11:43
hom3mad3
hom3mad3 requested changes Feb 19, 2024
View reviewed changes
adhocracy-plus/assets/scss/_fonts.scss Outdated
font-family: "SourceSerifPro";
src: url("../fonts/SourceSerifPro-Regular.otf");
font-family: "Cabin";
src: url("../fonts/Cabin-Regular.ttf");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should opt for a format that has better compression. woff2 is supported everywhere

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, there is no download for woff though, the repo only has ttf or otf (the linked download in the story only offered ttf, that's why I used it. Should we use otf then? Or is there a way to get a woff?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you usually need to use a webfont converter/generator. something like this or this

adhocracy-plus/assets/scss/_fonts.scss Outdated Show resolved Hide resolved
adhocracy-plus/assets/scss/_fonts.scss Show resolved Hide resolved
adhocracy-plus/assets/scss/_fonts.scss Show resolved Hide resolved
adhocracy-plus/assets/scss/_fonts.scss Outdated Show resolved Hide resolved
adhocracy-plus/assets/scss/_fonts.scss Outdated Show resolved Hide resolved
@goapunk goapunk force-pushed the jd-2024-02-change-styling branch from feb6f32 to e8552a0 Compare February 19, 2024 13:01
@goapunk goapunk requested a review from hom3mad3 February 19, 2024 13:16
@goapunk goapunk force-pushed the jd-2024-02-change-styling branch from e8552a0 to f30b9b0 Compare February 19, 2024 13:17
@goapunk goapunk force-pushed the jd-2024-02-change-styling branch from f30b9b0 to 9221ca5 Compare February 19, 2024 15:15
@hom3mad3 hom3mad3 merged commit 4cca6f1 into main Feb 19, 2024
3 checks passed
@hom3mad3 hom3mad3 deleted the jd-2024-02-change-styling branch February 19, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hom3mad3 hom3mad3 hom3mad3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@goapunk @hom3mad3