-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pdfs.hbs [WIP] #118
Add pdfs.hbs [WIP] #118
Conversation
surge: deployed to https://liputenpotest-118.surge.sh |
toki a! pona mute tawa sina tan pali sina a this looks great :) as the bot says, we can find a preview on https://liputenpotest-118.surge.sh/ (but because of filesize, the preview does not have PDFs) when I made the issue, I was just imagining a pretty plaintext-list, but the images and layout makes it look nice :) a few notes:
overall this is a wonderful change ! thanks for giving it an attempt :) I hope you find eleventy to your pleasure. with changes to the note of my notes, this is easily ready to merge and a good page (almost an easter egg of a page ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a final note: I prefer the header to stay lipu
rather than lipu pdf
- I hope this is understandable :)
Thanks again for the quick feedback!
I noticed that the long copy "lipu walo tawa ilo sitelen" used the full width and spilled over onto a second line. My final commit adds some styling changes to make each lipu wider so that each pdf link only uses one line. I think this looks a little better, but it's totally up to you whether you'd prefer not to add any additional CSS (or to go a different direction with the design of this page). |
the CSS is fine with me! this looks ready to merge !! only one thing I should have said before: I think we should put a link at the top of the page that says "download all" or similar (in toki pona), which links to https://github.com/lipu-tenpo/liputenpo.org/tree/main/pdfs after that I will merge it :) thank you for doing this |
Added in that link in a new line in the introduction section! |
I have made a small change to move the URL to thanks a lot for this !! I will merge and it should be visible on the site soon :) |
This is a first shot at issue #117.
A few notes:
stylesheet-index.css
and avoided adding more code to the css file. This means that added a few manual breaks into the hbs template. I believe this is simpler and more maintainable than editing the css to account for the flexbox spacing.Any and all feedback is welcome!