-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
light theme experimentation #113
base: main
Are you sure you want to change the base?
Conversation
a lot of css variables
surge: deployed to https://liputenpotest-113.surge.sh |
Overall I like this a lot! Maybe some of the colors could be tweaked a little, for example I think the link color could be darker. I would also be curious to see this without the patterned background, just a very light (near-white) color. |
I agree with the colours, some are still a little off do you think it's worth trying to have a dark/light switcher, or not ? |
Re: background, maybe could go for a lighter gray or even pure white, but I already prefer that to the tiling. Maybe that divider under the logo/menu could be a good place to add some color or a little pattern rather than a simple line. What do you think? Re: dark/light switcher, I don't mind not having it personally, but I do know that some people really appreciate having a dark mode available so if it's not too much work I think it's worth offering that. |
sounds good to me ! perhaps we could ask someone to draw a nice SVG separating line.
It should be okay. The only thing will be that the auto-generated colours (names/issues) will only really fit either the dark or light theme (or we would have to change how they are done) I may give this a go if I find some time. Otherwise, this will hang around |
an experiment with light theme
this is built upon #86 so that should be merged first
this is really just an experiment. what do you think ?
see deployment below
adds a CSS background (#89)
parameterised a lot of CSS variables for (easier) switching