Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: tool generate params TDE-632 #102

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

MDavidson17
Copy link
Contributor

nb: this branch may not be merged however the code will remain here fore the time being

to run:

  1. download the imagery parameters csv and convert to a csv
  2. save the csv in the tools directory, if you change the name/location you will need to change the PARAMETERS_CSV field
  3. run:
cd tools
python3 ./generate-argo-cli-commands.py | pjl

Output:

  • numerous parameter yaml files to be processed
  • a sh script containing all the argo commands which need to be run
  • logs detailing:
    • any datasets which also need to be imported into basemaps
    • any datasets which have been skipped and the reasons why

@paulfouquet paulfouquet changed the title Feat: tool generate params TDE-632 feat: tool generate params TDE-632 Feb 16, 2023
Copy link
Collaborator

@paulfouquet paulfouquet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MDavidson17
Copy link
Contributor Author

Example output:
tools.zip

@MDavidson17
Copy link
Contributor Author

updates based on reviews:

  • Some of the source path end with / some other without. I think aws-list handles that - trailing / stripped
  • The description shows up with 2 spaces on the line return, I don't know if there is an impact? - yarn.dumps has line length parameter - updated to 1000
  • bay-of-plenty-0_25m-rural-aerial-photos-(2011-2012).yaml for example referes BOPLASS Limited instead of BOPLASS in the licensor-list param - fixed is original spreadsheet
  • licensor added as empty if licensor-list
  • changed filenames to match target name
  • should we wrap the values in the yaml file in "" (WIP)

@MDavidson17 MDavidson17 force-pushed the feat/tool-generate-params branch 2 times, most recently from 104c53a to fadc7a3 Compare February 23, 2023 20:57
@MDavidson17 MDavidson17 force-pushed the feat/tool-generate-params branch 3 times, most recently from 2df6a7e to 51e9386 Compare March 30, 2023 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants