Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: notify buffer format in context #10

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

asterwyx
Copy link
Contributor

Source buffer format can be reused in context.

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: asterwyx

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zccrs
Copy link
Member

zccrs commented Nov 14, 2024

/+1

@asterwyx asterwyx changed the title refact: notify buffer format in context WIP: refact: notify buffer format in context Nov 20, 2024
@asterwyx asterwyx changed the title WIP: refact: notify buffer format in context WIP: notify buffer format in context Nov 20, 2024
@asterwyx asterwyx marked this pull request as draft November 20, 2024 04:44
@deepin-bot
Copy link

deepin-bot bot commented Nov 21, 2024

TAG Bot

New tag: 0.4.3
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #12

@asterwyx asterwyx force-pushed the capture branch 2 times, most recently from df312eb to e1560a7 Compare November 25, 2024 09:35
@asterwyx asterwyx changed the title WIP: notify buffer format in context feat: notify buffer format in context Nov 25, 2024
@asterwyx asterwyx marked this pull request as ready for review November 25, 2024 09:36
Source buffer format can be reused in context.
@deepin-ci-robot
Copy link

deepin pr auto review

代码审查意见:

  1. XML文档结构

    • <request name="start">中新增的<arg name="buffer" type="object" interface="wl_buffer" allow-null="true" summary="buffer to receive frame data, null for export dmabuf"/>,确保wl_buffer接口在文档中已定义,并且allow-null="true"是正确的使用场景。
  2. 事件描述

    • <event name="frame"><event name="dmabuf_frame">中,描述信息已经更新,确保这些描述准确反映了事件的功能和用途。
  3. 事件名称

    • 新增了<event name="dmabuf_object">,需要确认这个事件是否确实需要,以及它是否与现有的<event name="object">有区别。
  4. 事件顺序

    • <event name="dmabuf_frame">的描述中提到,这个事件总是直接在<event name="frame">之后发出,需要确认这一顺序是否在实现中得到了保证。
  5. 枚举类型

    • <event name="source_failed">中,枚举类型从source_failure更改为treeland_capture_context_v1.source_failure,需要确保新的枚举类型在文档中已定义,并且与旧类型兼容。
  6. 请求描述

    • <request name="capture"><request name="create_session">中,描述信息已经更新,确保这些描述准确反映了请求的功能和用途。
  7. 安全性

    • <request name="capture">的描述中提到,调用捕获意味着源被客户端确认且不会改变,这可能会导致安全问题。需要确保这一行为在实现中得到了适当的保护。
  8. 文档一致性

    • 整个文档的描述信息应该保持一致,确保每个事件、请求和枚举类型都有清晰的定义和用途。
  9. 性能考虑

    • 新增的事件和请求可能会影响性能,需要评估这些更改对现有系统的影响,并确保没有引入不必要的性能开销。
  10. 错误处理

    • <event name="source_failed">的描述中,提到了selector_busyuser_cancel两种失败原因,需要确保客户端能够正确处理这些错误,并给出适当的反馈。

总体来说,这些更改提高了文档的清晰度和准确性,但需要确保实现中能够正确处理这些新的功能和事件。

@deepin-bot
Copy link

deepin-bot bot commented Nov 26, 2024

TAG Bot

New tag: 0.4.4
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #15

@asterwyx asterwyx marked this pull request as draft November 27, 2024 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants