Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: write storage role fingerprint to /etc/fstab #458

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

richm
Copy link
Contributor

@richm richm commented Jul 23, 2024

Feature: Write storage role fingerprint to /etc/fstab

Reason: This will allow us to track usage of the storage role
on managed nodes.

Result: Storage role usage on managed nodes can be tracked.

Signed-off-by: Rich Megginson [email protected]

Feature: Write storage role fingerprint to /etc/fstab

Reason: This will allow us to track usage of the storage role
on managed nodes.

Result: Storage role usage on managed nodes can be tracked.

Signed-off-by: Rich Megginson <[email protected]>
Copy link

codecov bot commented Jul 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 10.76%. Comparing base (bb51979) to head (44a9333).
Report is 3 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (bb51979) and HEAD (44a9333). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (bb51979) HEAD (44a9333)
sanity 1 0
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #458      +/-   ##
==========================================
- Coverage   16.54%   10.76%   -5.79%     
==========================================
  Files           2        8       +6     
  Lines         284     1942    +1658     
  Branches       79        0      -79     
==========================================
+ Hits           47      209     +162     
- Misses        237     1733    +1496     
Flag Coverage Δ
sanity ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@richm richm requested review from vojtechtrefny and japokorn July 23, 2024 13:49
@richm richm merged commit d2dadb6 into linux-system-roles:main Jul 23, 2024
18 of 19 checks passed
@richm richm deleted the fingerprint branch July 23, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants