Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support missing domain-related endpoints for API parity #620

Merged
merged 4 commits into from
Nov 22, 2024

Conversation

yec-akamai
Copy link
Contributor

@yec-akamai yec-akamai commented Nov 19, 2024

📝 Description

Support the following domain related endpoints:

  • POST domains/$id/clone
  • POST domains/import

✔️ How to Test

make testunit
make fixtures ARGS="-run TestDomain_Clone_smoke"

@yec-akamai yec-akamai added the improvement for improvements in existing functionality in the changelog. label Nov 19, 2024
@yec-akamai yec-akamai requested a review from a team as a code owner November 19, 2024 15:53
@yec-akamai yec-akamai requested review from zliang-akamai and ykim-akamai and removed request for a team November 19, 2024 15:53
@@ -21,3 +23,16 @@ func mockRequestURL(t *testing.T, path string) *regexp.Regexp {
func createMockClient(t *testing.T) *linodego.Client {
return testutil.CreateMockClient(t, linodego.NewClient)
}

func formatMockAPIPath(format string, args ...any) string {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice helper function here 👍

Copy link
Contributor

@ykim-akamai ykim-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tests pass locally

Copy link
Member

@zliang-akamai zliang-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yec-akamai yec-akamai merged commit d464398 into main Nov 22, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement for improvements in existing functionality in the changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants